Do not clear CALayer contents when resizing macOS surfaces#357
Merged
mrobinson merged 1 commit intoJun 1, 2026
Merged
Conversation
The previous code was setting the layer contents to the freshly-allocated front buffer when resizing. This meant that the layer contents were blank (black) if painted to the screen before Servo had a chance to repaint into the surface. This change removes that extra work preserving the old contents. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
mrobinson
force-pushed
the
do-not-clear-contents-when-resizing-macos-surface
branch
from
1e6fa4a to
af1c4c7
Compare
mukilan
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was setting the layer contents to the
freshly-allocated front buffer when resizing. This meant that the layer
contents were blank (black) if painted to the screen before Servo had a
chance to repaint into the surface. This change removes that extra work
and ensures that the old contents are preserved.