add clear_namespace hook to BlobImageRenderer trait #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ welcome back! |
|
📌 Commit 3a744d4 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 19, 2018
add clear_namespace hook to BlobImageRenderer trait To deal with Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1448703, we need to be able to tell the BlobImageRenderer at a well-defined time when the namespace actually gets cleared, so that it can thus clear its resources at said time. This requires adding a new hook to the trait, since we only really know what time this actually happens when clear_namespace() is called on the resource cache. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2676) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1448703, we need to be able to tell the BlobImageRenderer at a well-defined time when the namespace actually gets cleared, so that it can thus clear its resources at said time. This requires adding a new hook to the trait, since we only really know what time this actually happens when clear_namespace() is called on the resource cache.
This change is