Skip to content

add clear_namespace hook to BlobImageRenderer trait #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2018
Merged

add clear_namespace hook to BlobImageRenderer trait #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions webrender/examples/blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ impl api::BlobImageRenderer for CheckerboardRenderer {
}
fn delete_font(&mut self, _font: api::FontKey) {}
fn delete_font_instance(&mut self, _instance: api::FontInstanceKey) {}
fn clear_namespace(&mut self, _namespace: api::IdNamespace) {}
}

struct App {}
Expand Down
4 changes: 4 additions & 0 deletions webrender/src/resource_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,6 +1105,10 @@ impl ResourceCache {
.retain(|key, _| key.0 != namespace);
self.cached_glyphs
.clear_fonts(|font| font.font_key.0 == namespace);

if let Some(ref mut r) = self.blob_image_renderer {
r.clear_namespace(namespace);
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions webrender_api/src/image.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ pub trait BlobImageRenderer: Send {
fn delete_font(&mut self, key: FontKey);

fn delete_font_instance(&mut self, key: FontInstanceKey);

fn clear_namespace(&mut self, namespace: IdNamespace);
}

pub type BlobImageData = Vec<u8>;
Expand Down
2 changes: 2 additions & 0 deletions wrench/src/blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,6 @@ impl BlobImageRenderer for CheckerboardRenderer {
fn delete_font(&mut self, _key: FontKey) {}

fn delete_font_instance(&mut self, _key: FontInstanceKey) {}

fn clear_namespace(&mut self, _namespace: IdNamespace) {}
}