-
Notifications
You must be signed in to change notification settings - Fork 301
Fix hue-rotate and saturate filter #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! There seem to be several unexpected fails in filter tests in that try run that look related though? Also, do the tests check for correctly working with pre-multiplied alpha? We should make sure we have some coverage for those too if not already. |
|
Oh, I think there is a bug after I move color matrix to vertex shader. I will fix it and add premultiplied alpha test as well. |
|
Looks good! Do we have / need a gecko try run for the updated PR? |
|
The try result is same: There are 5 unexpected fails. The max difference is only 1~2. So I will use fuzz for those tests. |
|
@bors-servo r+ |
|
📌 Commit f2909b4 has been approved by |
Fix hue-rotate and saturate filter The result of hue-rotate and saturate was wrong. I also create color matrix in vertex shader for those matrix type filters. After the fix, the gecko looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca4753a3913013cdc80bd5cbba81f2213ce9ae51&selectedJob=143243269 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2017) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
|
@demo99 This seems to have caused shader compilation failures on windows. See https://bugzilla.mozilla.org/show_bug.cgi?id=1415150#c7 - the try push that revealed it is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffb402d6fefebf42d40c88889b97a86340fda4fe |
|
There's a variable with the name webrender/webrender/res/ps_blend.glsl Lines 54 to 57 in 3b85b02
Maybe variable declarations aren't allowed within switch case branches without a nested scope, similar to C++? |
The result of hue-rotate and saturate was wrong. I also create color matrix in vertex shader for those matrix type filters.
After the fix, the gecko looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca4753a3913013cdc80bd5cbba81f2213ce9ae51&selectedJob=143243269
This change is