Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove StackingContext::scroll_policy #2747
Merged
Conversation
|
r? @glennw or anyone |
|
Since Gecko only uses ScrollPolicy:Scrollable, the only change necessary there should be to remove this argument from |
This can be handled in clients now that they have access to reference frame ciip ids. Removing fixed positioning support from WebRender simplifies the code greatly and also opens the way to explicit creation of reference frames in the API. It will also allow us to get rid of the hacky replacements code during display list flattening. This also requires exposing the root reference frame to Wrench tests in order to enable them retain the fixed positioning feature. This change exposes new aliases to wrench "root-scroll-node" and "root-reference-frame" in order to make this clearer. These nodes correspond to the ids 1 and 0 respectively and Wrench will halt if it encounters these used for other nodes.
mrobinson
force-pushed the
mrobinson:remove-fixed-stacking-contexts
branch
from
1d60f4f
to
f779ed6
|
Reviewed 48 of 48 files at r1. Comments from Reviewable |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 10, 2018
Remove StackingContext::scroll_policy This can be handled in clients now that they have access to reference frame ciip ids. Removing fixed positioning support from WebRender simplifies the code greatly and also opens the way to explicit creation of reference frames in the API. It will also allow us to get rid of the hacky replacements code during display list flattening. This also requires exposing the root reference frame to Wrench tests in order to enable them retain the fixed positioning feature. This change exposes new aliases to wrench "root-scroll-node" and "root-reference-frame" in order to make this clearer. These nodes correspond to the ids 1 and 0 respectively and Wrench will halt if it encounters these used for other nodes. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2747) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedMay 10, 2018
•
edited by larsbergstrom
This can be handled in clients now that they have access to reference
frame ciip ids. Removing fixed positioning support from WebRender
simplifies the code greatly and also opens the way to explicit creation
of reference frames in the API. It will also allow us to get rid of the
hacky replacements code during display list flattening.
This also requires exposing the root reference frame to Wrench tests in
order to enable them retain the fixed positioning feature. This change
exposes new aliases to wrench "root-scroll-node" and
"root-reference-frame" in order to make this clearer. These nodes
correspond to the ids 1 and 0 respectively and Wrench will halt if it
encounters these used for other nodes.
This change is