-
Notifications
You must be signed in to change notification settings - Fork 306
Remove image borders #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove image borders #818
Conversation
|
r? @glennw BTW, I removed the distinction between |
|
This generally looks good to me (I'll run the CSS tests locally to confirm). We'll need to apply the same clamp in the text run shader though. |
|
Good point @glennw , the text is now also converted. |
|
☔ The latest upstream changes (presumably #776) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This looks good, but will need to be rebased after the external texture images changes landed. |
|
@glennw rebased now |
|
Nice one! |
|
@bors-servo r+ |
|
📌 Commit 5b41357 has been approved by |
Remove image borders Fixes #789 Clamping the texture coordinates in pixel shaders (as well as using textureLod) to ensure sampling within original borders now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/818) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
@JerryShih there are 2 reasons for using textureLod in this case:
|
|
@kvark maybe worth adding these architectural decisions to the wiki? probably makes sense for any details that can answer "why not use X?" for common graphics tech. |
|
@leeoniya that should be a good start: |
|
excellent, thanks 👍 |
Fixes #789
Clamping the texture coordinates in pixel shaders (as well as using textureLod) to ensure sampling within original borders now.
This change is