Use cmake to generate the src/version.h file #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
requested changes
Oct 27, 2025
Doy-lee
force-pushed
the
cmake-make-version-file
branch
from
17d941c to
2f80029
Compare
``` ~/Cloud/Code/libsession-util-nodejs$ ./prepare_release.sh Package: 0.5.9; Commit: fe47f7e228a4affc77bf0729f40df408b4f3d8c2 Error: Version mismatch! package.json version is 0.5.9, but src/version.h has 0.5.10. Build the project first before packaging 'yarn install' ~/Cloud/Code/libsession-util-nodejs$ ./prepare_release.sh Package: 0.5.9; Commit: fe47f7e228a4affc77bf0729f40df408b4f3d8c2 Error: Version mismatch! Git commit is fe47f7e228a4affc77bf0729f40df408b4f3d8c2, but src/version.h has ee47f7e228a4affc77bf0729f40df408b4f3d8c2. Build the project first before packaging 'yarn install' ```
Bilb
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the extra
sh update_version.shscript from needing to be called by the user which means that to get started on the project you just need toyarn install, without it the build complains about a missingsrc/version.h.The version file is automatically built on the configuration step. The project automatically invokes the configuration step when you build via
yarn install(this is suboptimal but it's fine to reconfigure every time for a small project) so the version file is always regenerated.