Skip to content

Conversation

@SessionHero01
Copy link
Collaborator

@SessionHero01 SessionHero01 commented Nov 18, 2025

In this PR:

  1. Profile handling (name, pic) is pulled out of the Message class entirely. Now the UI code doesn't need to concern itself with attaching a profile when sending message, this is done automatically
  2. The toProto in the Message and its classes now accept a builder and only put in the their specific value. The base class will handle the common value, like expiry message, sent timestamp, pro features, etc. This makes sure that classes take on their responsibility correctly (so no more forgetting to apply expiration on new message types)
  3. The MessageSender is going to attach user profile, pro proof when sending the message itself (calling back to Point 1 so no UI will forget to do so)
  4. Remove a bunch of unused properties from the MessageRecord family, and add the pro features property accordingly.

@SessionHero01 SessionHero01 merged commit 574462b into dev Nov 18, 2025
4 checks passed
@SessionHero01 SessionHero01 deleted the pro-message-part-2 branch November 18, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants