Add pro_features into the message pipeline #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Messageclass entirely. Now the UI code doesn't need to concern itself with attaching a profile when sending message, this is done automaticallytoProtoin theMessageand its classes now accept a builder and only put in the their specific value. The base class will handle the common value, like expiry message, sent timestamp, pro features, etc. This makes sure that classes take on their responsibility correctly (so no more forgetting to apply expiration on new message types)MessageSenderis going to attach user profile, pro proof when sending the message itself (calling back to Point 1 so no UI will forget to do so)MessageRecordfamily, and add the pro features property accordingly.