Skip to content

Remove empty sub/unsub API requests #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

Remove empty sub/unsub API requests #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a38f657
Remove empty sub/unsub API requests
SessionHero01 Nov 25, 2025
72a1838
Merge branch 'dev' into remove-empty-sub-requests
SessionHero01 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/java/org/thoughtcrime/securesms/notifications/PushRegistrationHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class PushRegistrationHandler @Inject constructor(
@param:ManagerScope private val scope: CoroutineScope,
@param:PushNotificationModule.PushProcessingSemaphore
private val semaphore: Semaphore,
private val storage: StorageProtocol,
private val pushRegistrationDatabase: PushRegistrationDatabase,
private val loginStateRepository: LoginStateRepository,
) : OnAppStartupComponent {
Expand Down
5 changes: 4 additions & 1 deletion app/src/main/java/org/thoughtcrime/securesms/notifications/PushRegistrationWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import org.session.libsession.database.userAuth
import org.session.libsession.messaging.sending_receiving.notifications.Response
import org.session.libsession.snode.SwarmAuth
import org.session.libsession.utilities.ConfigFactoryProtocol
import org.session.libsession.utilities.TextSecurePreferences
import org.session.libsignal.exceptions.NonRetryableException
import org.session.libsignal.utilities.AccountId
import org.session.libsignal.utilities.IdPrefix
Expand Down Expand Up @@ -173,6 +172,10 @@ class PushRegistrationWorker @AssistedInject constructor(
buildRequest: (T) -> Req,
sendBatchRequest: suspend (Collection<Req>) -> List<Res>,
): List<Pair<T, kotlin.Result<Unit>>> {
if (items.isEmpty()) {
return emptyList()
}

val results = ArrayList<Pair<T, kotlin.Result<Unit>>>(items.size)

val batchRequestItems = mutableListOf<T>()
Expand Down