Pro Stats #1730
Merged
Pro Stats #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return count; | ||
| } | ||
|
|
||
| public int getOutgoingFeatureCount(ProFeature feature) { |
Collaborator
There was a problem hiding this comment.
I think this should be ProMessageFeature
app/src/main/java/org/thoughtcrime/securesms/database/SmsDatabase.java
Outdated
Show resolved
Hide resolved
Comment on lines
132
to
133
| "(($PRO_MESSAGE_FEATURES & $featureMask) != 0 OR " + | ||
| " ($PRO_PROFILE_FEATURES & $featureMask) != 0) AND $outgoingSelection" |
Collaborator
There was a problem hiding this comment.
I think this query might be incorrect. I don't think you would like to OR these two together because they have completely different meaning
Collaborator
Author
There was a problem hiding this comment.
Ah yeah of course, as those values might be the same in the two different categories. I'll fix it.
|
|
||
| override fun getTotalPinned(): Int { | ||
| return configFactory.withUserConfigs { | ||
| override suspend fun getTotalPinned(): Int = withContext(Dispatchers.IO) { |
Collaborator
There was a problem hiding this comment.
I don't think you need to run config query on a separate thread - it's in memory data anyway
Collaborator
Author
There was a problem hiding this comment.
It was for the benefit of having a suspend function for the async thread count, but I can revert that's ok
SessionHero01
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the preliminary work to integrate Pro Stats
Fixed formatting of chars left in text input
Also added QA tags for CTAs