Feature/community link handling by ThomasSession · Pull Request #2049 · session-foundation/session-android

ThomasSession · 2026-03-16T06:04:50Z

New way to handle community link throughout the application.

… from search

Copilot

Pull request overview

This PR introduces a centralized link-classification flow (generic vs. community links) and updates multiple entry points (conversations, search, new-message flows, join/create community flows) to use a unified dialog + handling behavior across the app.

Changes:

Added LinkChecker/LinkRule infrastructure and a CommunityLinkRule to classify/normalize URLs into LinkType.
Introduced a new Compose LinkAlertDialog that renders either a generic open/copy dialog or a community join/open dialog depending on LinkType.
Updated multiple screens/viewmodels (Conversation V2/V3, Start Conversation, Global Search, Join/Create Community) to route link interactions through the new link handling.

Reviewed changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
app/src/test/java/org/thoughtcrime/securesms/links/LinkCheckerTest.kt	Adds unit tests for URL classification.
app/src/test/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModelTest.kt	Updates tests for new link handling behavior.
app/src/main/java/org/thoughtcrime/securesms/ui/dialog/LinkDialog.kt	New unified link dialog UI.
app/src/main/java/org/thoughtcrime/securesms/ui/dialog/AlertDialog.kt	Moves dialog components into `ui.dialog` package.
app/src/main/java/org/thoughtcrime/securesms/ui/components/QR.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/ui/components/ExportLogsDialog.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/ui/UserProfileModal.kt	Updates dialog import + formatting.
app/src/main/java/org/thoughtcrime/securesms/ui/ProComponents.kt	Uses dialog components from new package.
app/src/main/java/org/thoughtcrime/securesms/tokenpage/TokenPage.kt	Updates `OpenURLAlertDialog` import path.
app/src/main/java/org/thoughtcrime/securesms/search/SearchRepository.kt	Expands contact search to include exact ID match.
app/src/main/java/org/thoughtcrime/securesms/reviews/ui/InAppReview.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/recoverypassword/RecoveryPassword.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/preferences/prosettings/ProSettingsViewModel.kt	Updates `SimpleDialogData` import path.
app/src/main/java/org/thoughtcrime/securesms/preferences/prosettings/ProSettingsDialogs.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/preferences/prosettings/BaseProSettingsScreens.kt	Updates `DialogBg` import path.
app/src/main/java/org/thoughtcrime/securesms/preferences/compose/PrivacySettingsPreferenceScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/preferences/compose/NotificationsPreferenceScreen.kt	Removes unused import + updates dialog imports.
app/src/main/java/org/thoughtcrime/securesms/preferences/appearance/AppDisguiseSettings.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/preferences/SettingsViewModel.kt	Updates `SimpleDialogData` import path.
app/src/main/java/org/thoughtcrime/securesms/preferences/SettingsScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/preferences/QRCodeActivity.kt	Switches QR parsing/validation to `AccountId`.
app/src/main/java/org/thoughtcrime/securesms/preferences/BlockedContactsScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/onboarding/landing/Landing.kt	Updates `TCPolicyDialog` import path.
app/src/main/java/org/thoughtcrime/securesms/onboarding/OnboardingBackPressAlertDialog.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/migration/DatabaseMigrationScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/media/MediaOverviewScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/links/LinkChecker.kt	Adds link classification entry point + `LinkType`.
app/src/main/java/org/thoughtcrime/securesms/links/CommunityLinkRule.kt	Adds community URL classification rule.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/newmessage/NewMessageViewModel.kt	Adds community URL detection + join/open behavior.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/group/CreateGroupViewModel.kt	Detects community URLs in group name + dialog flow.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/group/CreateGroupScreen.kt	Displays `LinkAlertDialog` for URL detection.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/community/JoinCommunityViewModel.kt	Uses `LinkChecker` to detect already-joined communities.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/community/JoinCommunityScreen.kt	Displays `LinkAlertDialog` for joined-community case.
app/src/main/java/org/thoughtcrime/securesms/home/startconversation/StartConversationSheet.kt	Uses assisted factory VM + unified link dialog.
app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchViewModel.kt	Adds special-case handling for community URLs & account IDs.
app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchResult.kt	Adds `urlDialog` slot to search result model.
app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchInputLayout.kt	Removes search input length filter.
app/src/main/java/org/thoughtcrime/securesms/home/HomeViewModel.kt	Adds dialog + command handling for link/community flows from search.
app/src/main/java/org/thoughtcrime/securesms/home/HomeDialogs.kt	Uses `LinkAlertDialog` in Home dialogs.
app/src/main/java/org/thoughtcrime/securesms/home/HomeActivity.kt	Wires GlobalSearch UI events into HomeViewModel.
app/src/main/java/org/thoughtcrime/securesms/groups/compose/PromoteMembersScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/groups/compose/ManageGroupMembersScreen.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/groups/compose/ManageGroupAdminsScreen.kt	Updates `LoadingDialog` import path.
app/src/main/java/org/thoughtcrime/securesms/groups/compose/InviteAccountIdScreen.kt	Switches to unified link dialog field (`urlDialog`).
app/src/main/java/org/thoughtcrime/securesms/groups/compose/Components.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/debugmenu/DebugMenu.kt	Updates dialog imports + command references.
app/src/main/java/org/thoughtcrime/securesms/database/Storage.kt	Removes legacy closed-group API usage.
app/src/main/java/org/thoughtcrime/securesms/database/LokiAPIDatabase.kt	Removes legacy closed-group check method.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/settings/ConversationSettingsViewModel.kt	Passes address into destinations for nav correctness.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/settings/ConversationSettingsScreen.kt	Updates `LoadingDialog` import path.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/settings/ConversationSettingsNavHost.kt	Makes destinations carry address; updates backstack handling.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/settings/ConversationSettingsDialogs.kt	Updates dialog imports to new package.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/settings/ConversationSettingsActivity.kt	Requires address and seeds start destination with it.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/message/MessageLink.kt	Routes link clicks through `HandleLink`.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/message/CommunityInviteMessage.kt	Makes invites clickable + trims query param display.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/message/BaseMessage.kt	Routes URL clicks through unified link handling.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/conversation/ConversationV3Dialogs.kt	Replaces URL/community dialogs with `LinkAlertDialog`.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/compose/conversation/ConversationScreen.kt	Threads address through to settings navigation.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationV3ViewModel.kt	Adds link checker + community join/open flow in convo.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationV3NavHost.kt	Makes destinations carry address; updates VM creation.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationModels.kt	Replaces old URL/community dialog fields with `LinkType`.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationCommand.kt	Replaces `OpenUrl`/join-community commands with link commands.
app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationActivityV3.kt	Seeds navhost with address; updates switching behavior.
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageContentView.kt	Routes URL taps through new `handleLink` entry point.
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/LinkPreviewView.kt	Routes URL taps through new `handleLink` entry point.
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationViewModel.kt	Adds `LinkChecker` + unified dialog/join logic.
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationV2Dialogs.kt	Replaces URL/community dialogs with `LinkAlertDialog`.
app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt	Renames URL dialog entry point to `handleLink`; fixes nav args.
app/src/main/java/org/thoughtcrime/securesms/InputbarViewModel.kt	Updates `SimpleDialogData` import path.
app/src/main/java/org/thoughtcrime/securesms/InputBarDialogs.kt	Updates dialog imports to new package.
app/src/main/java/org/session/libsignal/utilities/Validation.kt	Removes legacy `PublicKeyValidation`.
app/src/main/java/org/session/libsignal/utilities/AccountId.kt	Adds `hasValidLength` helper.
app/src/main/java/org/session/libsignal/database/LokiAPIDatabaseProtocol.kt	Removes legacy `isClosedGroup` API.
app/src/main/java/org/session/libsession/database/StorageProtocol.kt	Removes legacy `isLegacyClosedGroup` API.

Comments suppressed due to low confidence (1)

app/src/main/java/org/thoughtcrime/securesms/ui/dialog/AlertDialog.kt:50

There are several unused imports here (e.g., Phrase, COMMUNITY_NAME_KEY, URL_KEY, LinkType, copyURLToClipboard, and Toast). Please remove them to avoid lint/ktlint failures and keep the module clean.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

ThomasSession · 2026-03-17T02:52:12Z

+                    var results = searchRepository.query(query).toGlobalSearchResult()
+
+                    // Special cases
+                    // community URL detected
+                    val communityUrl = linkChecker.check(query) as? LinkType.CommunityLink
+                    if(communityUrl != null){
+                        // if the community is joined, add it to the result,
+                        // otherwise show a confirmation dialog
+                        if(communityUrl.joined){
+                            // community is already joined: add it to the result list
+                            val openGroup = OpenGroupUrlParser.parseUrl(communityUrl.url)
+                            results = results.copy(
+                                threads = results.threads + recipientRepository.getRecipientSync(
+                                    Address.Community(
+                                        serverUrl = openGroup.server,
+                                        room = openGroup.room
+                                    )
+                                )
+                            )
+                        } else {
+                            // community not yet joined: show a confirmation dialog
+                            _uiEvents.emit(UiEvent.ShowUrlDialog(communityUrl.copy(displayType = LinkType.CommunityLink.DisplayType.SEARCH)))
+                        }
+                    }
+
+                    // Account ID detected, which is not a contact
+                    val accountId = AccountId.fromStringOrNull(query)
+                    val isStandardAccountId = accountId?.prefix == IdPrefix.STANDARD
+                    if(isStandardAccountId && !results.contacts.any { it.address.toString() == query }){
+                        _uiEvents.emit(UiEvent.ShowNewConversationDialog(Address.Standard(accountId)))
+                    }


I moved the UI events part out of that loop

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…session-foundation/session-android into feature/community-link-handling

ThomasSession added 17 commits March 11, 2026 15:25

Moved AlertDialog

c8e8b39

New way to handle links

bed4708

v3 dialog update

0124ea6

Hooking up the community join message

1879b16

Linking open/join community actions

390c098

Making sure we can format the text

4e9febb

Moved address ownership to permit navigation from convo to convo

18d814e

Cleaning up accountId validation and adding community link handling

7e5b3d8

simplified logic

1b047d9

Open or join community with confirmation in "New Message"

b280a11

Merge branch 'dev' into feature/community-link-handling

c8af9e2

Community link handling in create group

a72d89a

Join community "already joined" confirmation

75e2d0f

Merge branch 'dev' into feature/community-link-handling

647bfb2

Proper strings

945e2eb

Community link handling in search

25d29cc

Can now search users by their ID and start convo when not yet contact…

ec6d6aa

… from search

ThomasSession requested review from SessionHero01 and jbsession March 16, 2026 06:04

Merge branch 'dev' into feature/community-link-handling

94a69a7

SessionHero01 requested a review from Copilot March 16, 2026 23:09

Copilot started reviewing on behalf of SessionHero01 March 16, 2026 23:09 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

Potential fix for pull request finding

6cc4f5b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

SessionHero01 reviewed Mar 16, 2026

View reviewed changes

Comment thread app/src/main/java/org/thoughtcrime/securesms/conversation/v3/ConversationV3NavHost.kt

Comment thread app/src/main/java/org/thoughtcrime/securesms/links/CommunityLinkRule.kt

ThomasSession added 5 commits March 17, 2026 13:40

PR feedback: moving ui events derived from search query

1d76ede

Making the check suspend

c91c63b

Merge branch 'dev' into feature/community-link-handling

a3bc814

Fixed tests

f07769b

Merge branch 'feature/community-link-handling' of https://github.com/…

efaa3fa

…session-foundation/session-android into feature/community-link-handling

SessionHero01 approved these changes Mar 17, 2026

View reviewed changes

jbsession approved these changes Mar 17, 2026

View reviewed changes

ThomasSession merged commit b8ed9f8 into dev Mar 17, 2026
5 checks passed

ThomasSession deleted the feature/community-link-handling branch March 17, 2026 04:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/community link handling#2049

Feature/community link handling#2049
ThomasSession merged 24 commits intodevfrom
feature/community-link-handling

ThomasSession commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

ThomasSession Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ThomasSession commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

ThomasSession Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants