[SES-5366] - Reimplement how we handle mark read for notification#2074
Merged
SessionHero01 merged 4 commits intodevfrom Mar 25, 2026
Merged
[SES-5366] - Reimplement how we handle mark read for notification#2074SessionHero01 merged 4 commits intodevfrom
SessionHero01 merged 4 commits intodevfrom
Conversation
ThomasSession
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So if "mark read" is tapped, we will calculate the latest message + reaction timestamp for the given thread, and use that timestamp as the "last seen".
Previously we are using the timestamp from the notification calculation but it's very tricky for the name only convo. So we'll now just take the latest timestamp instead