-
Notifications
You must be signed in to change notification settings - Fork 5
fix: ci deps #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci deps #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a step to install system-level dependencies (libcurl4-openssl-dev, build-essential, and python3) required for building native Node.js modules in the CI environment.
- Adds a new step to install Linux system dependencies for native module compilation
- Placed before the "Install yarn" step in the setup action
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github/actions/setup/action.yml
Outdated
| with: | ||
| node-version-file: '.nvmrc' | ||
|
|
||
| - name: Install dependencies for native modules |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new step is missing the required 'shell' specification. In composite actions, every step that uses 'run' must explicitly specify a shell. Add 'shell: bash' to be consistent with the other steps in this action.
| - name: Install dependencies for native modules | |
| - name: Install dependencies for native modules | |
| shell: bash |
github/actions/setup/action.yml
Outdated
| with: | ||
| node-version-file: '.nvmrc' | ||
|
|
||
| - name: Install dependencies for native modules |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action is described as "Setup environment for both platforms" and is used by both iOS (macOS runners) and Android (Linux runners) workflows. However, this step uses Linux-specific package management (apt-get) which will fail on macOS runners. Consider adding a conditional to only run this step on Linux runners, or check the OS before executing.
| - name: Install dependencies for native modules | |
| - name: Install dependencies for native modules | |
| if: runner.os == 'Linux' |
github/actions/setup/action.yml
Outdated
|
|
||
| - name: Install dependencies for native modules | ||
| run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev build-essential python3 | ||
|
|
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is trailing whitespace at the end of this line. Remove the trailing spaces to maintain consistency with the codebase.
No description provided.