Skip to content

Conversation

@Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Dec 2, 2025

SESSION_DISABLE_IMAGE_PROCESSOR=1 environment variable to disable the use of the image processor. Generated link preview images will no longer work and display pictures are limited to non-animated images.

Copilot AI review requested due to automatic review settings December 2, 2025 00:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a feature flag disableImageProcessor to disable the main image processor and provide a fallback implementation using the Canvas API. This allows the application to continue processing avatar images even when the main image processor is disabled or unavailable.

  • Added disableImageProcessor feature flag with environment variable support
  • Implemented Canvas-based fallback image processor for avatar processing
  • Added error handling to catch image processor failures and use the fallback

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
ts/state/ducks/types/releasedFeaturesReduxTypes.ts Added disableImageProcessor boolean feature flag to the type definition
ts/state/ducks/types/defaultFeatureFlags.ts Configured default value for disableImageProcessor based on environment variable SESSION_DISABLE_IMAGE_PROCESSOR
ts/webworker/workers/browser/image_processor_interface.ts Added feature flag check to throw error when image processor is disabled
ts/util/avatar/processAvatarData.ts Implemented processImageFallback using Canvas API and added try-catch to fall back when main processor fails

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Aerilym Aerilym changed the title fix: add image processor disabled flag alternate processor fix: add image processor disabled flag with alternate processor Dec 2, 2025
@Aerilym Aerilym force-pushed the fix/add_image_processing_alternative branch from 47a5455 to 6c23e43 Compare December 2, 2025 02:25
@Aerilym Aerilym force-pushed the fix/add_image_processing_alternative branch from 2dd7e57 to 12ad9d4 Compare December 2, 2025 22:25
@Bilb Bilb merged commit 154cf33 into dev Dec 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants