fix: minor performance optimisations #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements minor performance optimizations to the i18n (internationalization) system by introducing caching for the browser locale calculation and reducing unnecessary function exports.
- Caches the browser locale value to avoid repeated computation of locale matching
- Makes internal helper function
normalizeLocaleNameprivate to better encapsulate implementation details
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ts/util/i18n/shared.ts | Adds caching mechanism for getBrowserLocale() by introducing a module-level browserLocale variable and refactoring the logic into getInitialBrowserLocale() |
| ts/node/locale.ts | Changes normalizeLocaleName from exported to private function, improving encapsulation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.