fix: click events for debug menu toggle in the settings page#1859
Merged
Conversation
Bilb
reviewed
Feb 23, 2026
ts/components/dialog/user-settings/pages/DefaultSettingsPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR fixes click event handlers for the debug menu toggle in the settings page. The previous implementation incorrectly used keyboard event handlers as click handlers, passing null as any as a fake event. This PR properly separates click and keyboard handlers and enhances the debug mode toggle to support both enabling and disabling, with user feedback via toast notifications.
Changes:
- Refactored event handlers to properly separate onClick and onKeyDown logic
- Fixed debug mode toggle to support both enabling and disabling (previously only enabled)
- Added toast notification feedback when toggling debug mode
- Fixed click counter logic using functional setState to avoid stale closures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.