Added SceneDelegate, refactored SessionBackgroundTask, crash fixes#684
Merged
mpretty-cyro merged 6 commits intosession-foundation:masterfrom Mar 31, 2026
Merged
Conversation
• Added a SceneDelegate to stop Xcode complaining that we don't have one • Added code to skip render actions in the HomeVC and ConversationVC if the app is (actually) in the background - now that we have updated to using `connectedScenes` we don't need to worry about "foregroundInactive" causing missed rendering • Added code to dedupe home screen nav updates (would happen everything and and are generally redundant) • Tweaked the logic for the ScreenLock to ensure it's in place before the `LoadingViewController` is replaced by the `HomeVC` (prevent brief leak) • Attempt to fix the spdlog shutdown crash • Attempt to fix a UITableView internal inconsistency crash (when dequeuing an unregistered cell) • Attempt to fix a crash where a VoIP call could result in a crash when received via PN due to the CallManager being initialised async • Attempt to fix a UI-on-background-thread crash • Attempt to minimise more '0xdead10cc' exceptions by avoiding File I/O when checking `canPerformChange` in LibSession (done when processing each message) • Fixed a crash where configuring the camera on a background thread could cause a crash
mpretty-cyro
added
bug
RyanRory
approved these changes
Mar 30, 2026
RyanRory
approved these changes
Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomeVCandConversationVCif the app is (actually) in the background - now that we have updated to usingconnectedSceneswe don't need to worry about "foregroundInactive" causing missed renderingLoadingViewControlleris replaced by theHomeVC(prevent brief leak)canPerformChangein LibSession (done when processing each message)