refactor: move filter state management to zustand store

[setchy]

No description provided.

[netlify]

✅ Deploy Preview for atlassify canceled.

Name	Link
🔨 Latest commit	be3c0af
🔍 Latest deploy log	https://app.netlify.com/projects/atlassify/deploys/698892260e453500081a84d5

[Copilot]

Pull request overview

Refactors notification filter state to live in a persisted zustand store (instead of being part of SettingsState / AppContext), and updates filtering logic + UI routes/components/tests to use the new store-backed filter state.

Changes:

• Introduce useFiltersStore (zustand + persist) and persist filter selections under a new storage key.
• Refactor notification filtering utilities and filter implementations to read filter state from the store.
• Update filter-related UI (Filters route/sections, sidebar/all-read) and tests to use the new store model.

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
src/renderer/utils/notifications/notifications.ts	Switch filtering callsite to filterNotifications(notifications) (store-backed).
src/renderer/utils/notifications/filters/types.ts	Update filter interface to remove SettingsState dependency and improve docs.
src/renderer/utils/notifications/filters/readState.ts	Read read-state filters from useFiltersStore.
src/renderer/utils/notifications/filters/readState.test.ts	Update tests to use store-based filters (but mocks need correction).
src/renderer/utils/notifications/filters/product.ts	Read product filters from useFiltersStore.
src/renderer/utils/notifications/filters/product.test.ts	Update tests to use store-based filters (but mocks need correction).
src/renderer/utils/notifications/filters/filter.ts	Refactor filtering/active-filter detection to use the zustand store.
src/renderer/utils/notifications/filters/filter.test.ts	Update filter tests for store model (but mocks need correction).
src/renderer/utils/notifications/filters/engagement.ts	Read engagement filters from useFiltersStore.
src/renderer/utils/notifications/filters/engagement.test.ts	Update tests to use store-based filters (but mocks need correction).
src/renderer/utils/notifications/filters/category.ts	Read category filters from useFiltersStore.
src/renderer/utils/notifications/filters/category.test.ts	Update tests to use store-based filters (but mocks need correction).
src/renderer/utils/notifications/filters/actor.ts	Read actor filters from useFiltersStore.
src/renderer/utils/notifications/filters/actor.test.ts	Update tests to use store-based filters (but mocks need correction).
src/renderer/utils/api/graphql/generated/graphql.ts	Regenerated GraphQL types/enums.
src/renderer/types.ts	Remove filter settings from SettingsState (but type cleanup needed).
src/renderer/stores/useFiltersStore.ts	New zustand store + persist for filter state.
src/renderer/routes/Filters.tsx	Use store-backed clearFilters and new filter keys.
src/renderer/routes/Filters.test.tsx	Update route tests to assert store action calls.
src/renderer/context/defaults.ts	Remove default filter settings from settings defaults.
src/renderer/context/App.tsx	Remove filter actions from context; trigger fetches based on store filter slices.
src/renderer/context/App.test.tsx	Remove tests for removed context filter methods.
src/renderer/constants.ts	Add FILTERS_STORE_KEY for persisted filter state.
src/renderer/components/filters/FilterSection.tsx	Use store-backed updateFilter and store-based isFilterSet.
src/renderer/components/filters/FilterSection.test.tsx	Update tests to use store-based action spying.
src/renderer/components/Sidebar.tsx	Use hasActiveFilters() without settings param (store-backed).
src/renderer/components/Sidebar.test.tsx	Update tests for store-based active filters (but mocks need correction).
src/renderer/components/AllRead.tsx	Use hasActiveFilters() without settings param (store-backed).
src/renderer/components/AllRead.test.tsx	Update tests for store-based active filters (but mocks need correction).
src/renderer/mocks/state-mocks.ts	Remove filter fields from mocked settings.
src/renderer/helpers/test-utils.tsx	Add mockFilterStoreState helper for stubbing filter store state.
pnpm-lock.yaml	Add zustand dependency lock entries.
package.json	Add zustand dependency.
.vscode/settings.json	Add partialize to cSpell words.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

src/renderer/components/filters/FilterSection.tsx:53

• FilterSection isn’t subscribed to the filters store state, so isChecked is computed once from useFiltersStore.getState() (via filter.isFilterSet) and won’t update after updateFilter runs. This can leave the checkbox UI stale and can repeatedly dispatch the wrong checked value (because !isChecked is based on an out-of-date render). Subscribe to the relevant slice (e.g. useFiltersStore(s => s[filterSetting])) and derive isChecked from that, or pass the selected values into the filter instead of having filters read the store directly.

  const { notifications } = useAppContext();
  const updateFilter = useFiltersStore((s) => s.updateFilter);

  return (
    <Stack space="space.050">
      <Heading size="small">{title}</Heading>
      <Box>
        {(Object.keys(filter.FILTER_TYPES) as T[]).map((type) => {
          const typeDetails = filter.getTypeDetails(type);
          const typeLabel = formatProperCase(typeDetails.name);
          const isChecked = filter.isFilterSet(type);
          const count = filter.getFilterCount(notifications, type);

          return (
            <Inline
              alignBlock="center"
              key={typeDetails.name}
              space="space.050"
            >
              <Checkbox
                aria-label={typeDetails.name}
                isChecked={isChecked}
                label={typeLabel}
                onChange={() => updateFilter(filterSetting, type, !isChecked)}
              />

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

updateFilter uses any for value and builds the next array with [...] which can introduce duplicates. This weakens type-safety and can bloat persisted state. Consider typing updateFilter generically (value as FiltersState[K][number] | FiltersState[K]) and, when checked === true, avoid adding the value if it already exists.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud