File actions, in-app auto-update, and titlebar focus-bug fix#4
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… cleanup, wait cap, non-dismissable panel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AppKit resets `titlebarAppearsTransparent` to `false` during window reactivation — a beat after the didBecomeKey/didBecomeMain notifications fire — which lets the opaque system titlebar overdraw the custom one. Re-applying on those notifications loses the race. WindowAccessor now KVO-observes `titlebarAppearsTransparent` and re-applies the window config synchronously whenever the property is knocked back to `false`, regardless of when AppKit does it. KVO callbacks run synchronously inside the property-set, so the value is corrected within the same runloop turn, before the window draws. Also: make `configureWindow` skip reassigning `styleMask` when it is already correct (avoids needless NSThemeFrame rebuilds now that the config re-applies on activation). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
markee | 41b8329 | Commit Preview URL Branch Preview URL |
May 19 2026, 04:10 AM |
SwiftLint --strict (run in CI) flags `String.data(using:)!` via the non_optional_string_data_conversion rule. Switch the two JSON-fixture literals to `Data(string.utf8)`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkeeWebView(WKWebView subclass) appends the two commands to the native right-click menu.Updater: checks the GitHub Releases API on launch (throttled to once/24h) and via "Check for Updates…" in the app menu; on a newer release it downloadsMarkee.app.zip, unzips withditto, validates the bundle, strips the quarantine xattr, and a detached helper swaps the running bundle and relaunches. Falls back to opening the release page when the install path isn't writable.titlebarAppearsTransparenttofalseduring reactivation;WindowAccessornow KVO-observes the property and re-applies the config synchronously whenever it's clobbered.Grouped/tabbed windows were considered and deferred. The app remains ad-hoc signed (not notarized), so the updater stays out of Sparkle's path and strips quarantine itself.
Test Plan
make test— 43 Swift + 24 Node tests passCFBundleShortVersionString, run, Check for Updates → Update Now → confirm download/swap/relaunch with no Gatekeeper prompt and no leftoverMarkee.app.old🤖 Generated with Claude Code