-
Notifications
You must be signed in to change notification settings - Fork 0
fix: pr labels #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pr labels #110
Conversation
Reviewer's Guide by SourceryThis pull request updates the PR labeling workflow to fetch secrets from 1Password and run on the Sequence diagram for PR notification workflow with 1Password integrationsequenceDiagram
participant GH as GitHub
participant Runner as namespace-profile-btp-docs Runner
participant OP as 1Password
participant Slack as Slack
GH->>Runner: Trigger PR workflow
Runner->>OP: Load secrets
OP-->>Runner: Return PR Slack webhook URL
alt PR has reviewers and not draft
Runner->>Slack: Send notification with reviewers
else PR not draft
Runner->>Slack: Send notification without reviewers
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @snigdha920 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| runs-on: ubuntu-latest | ||
| runs-on: namespace-profile-btp-docs | ||
| steps: | ||
| - uses: fuxingloh/multi-labeler@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider pinning this action to a specific commit hash for security, like the other actions in pr-settings.yml
Suggested implementation:
- uses: fuxingloh/multi-labeler@c97de6e4c5d8066a2fa0f1e9b0a3d30c0b9e1d8c
The exact commit hash I provided (c97de6e4c5d8066a2fa0f1e9b0a3d30c0b9e1d8c) should be verified against the latest stable commit in the fuxingloh/multi-labeler repository's v4 branch to ensure you're using the most recent secure version.
Summary by Sourcery
Update PR workflow to fetch secrets from 1Password and run on the
namespace-profile-btp-docsrunner.CI:
namespace-profile-btp-docs.