-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/documentation images #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates image paths and restructures the layout of documentation pages to improve image handling and overall presentation. It replaces ContentCard components with a more direct HTML/CSS approach for displaying blockchain information. Class diagram showing component structure changesclassDiagram
class ContentCard {
-image
-title
-description
-page
}
class BlockchainCard {
+blockchain-logo-wrapper
+blockchain-logo
+blockchain-title
+blockchain-description
}
note for ContentCard "Removed component"
note for BlockchainCard "New HTML/CSS structure"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SaeeDawod - I've reviewed your changes - here's some feedback:
Overall Comments:
- Ensure that all image paths are consistent. In some places you use absolute paths (e.g. '/documentation/img/...') and in others relative ones (e.g. 'img/about-settlemint/...'). Verify that these paths work correctly in production and consider standardizing them.
- Consider moving the inline CSS in the MDX file to an external stylesheet or CSS module. This could help maintain consistency and simplify future style updates.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update image paths in documentation and remove unused components.
Enhancements:
Documentation: