-
Notifications
You must be signed in to change notification settings - Fork 0
fixed a the main tittle and button in dark mode #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request addresses styling issues in the index.module.css file by updating the color attributes for the main title and the secondary button elements. The changes ensure that these components have the correct color themes in both dark and light modes by utilizing data attribute selectors. Updated class diagram for CSS classes (.heroBanner and .secondaryButton)classDiagram
class heroBanner {
+background-image: url(../../static/img/hero-background/Gradient-Banner.png)
+background-repeat: no-repeat
+background-size: cover
+font-family: 'Figtree', sans-serif
// color is now applied via theme-specific selectors
}
note for heroBanner "Color for heroBanner is set via [data-theme='dark'] (#ffff) and [data-theme='light'] (#1c1c1c)"
class secondaryButton {
+background-color: transparent
+padding: 0.8rem 1.25rem
+border-radius: 6px
+transition: all 0.3s ease-in-out
+font-family: 'Figtree', sans-serif
+font-size: 0.9375rem
+font-weight: 700
+text-transform: uppercase
+line-height: 1.5
+text-align: center
+vertical-align: middle
// color and border are now theme-driven
}
note for secondaryButton "secondaryButton color and border: dark mode uses #ffffff; light mode uses #1c1c1c (applied via specific selectors)"
Flow diagram for dark/light mode theming updatesflowchart TD
A[Start: Read data-theme attribute]
B{Is theme dark?}
C[Apply dark mode style to .heroBanner
color: #ffff]
D[Apply dark mode style to .secondaryButton
color: #ffffff, border: #ffffff]
E[Apply light mode style to .heroBanner
color: #1c1c1c]
F[Apply light mode style to .secondaryButton
color: #1c1c1c, border: #1c1c1c]
A --> B
B -- Yes --> C
B -- Yes --> D
B -- No --> E
B -- No --> F
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SaeeDawod - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using CSS variables to manage theme-dependent colors instead of using
data-themeattributes.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Bug Fixes: