-
Notifications
You must be signed in to change notification settings - Fork 0
fix: missing networks #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds documentation and support for two new blockchain networks: Sonic (L1) and Soneium (L2). It also includes minor formatting updates to the Hedera documentation. The changes involve creating new markdown files for Sonic and Soneium, updating the network manager documentation to include these networks, and modifying the Hedera documentation. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bl0up - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a short description of the consensus mechanism for Sonic and Soneium in the network manager documentation.
- The logos added in this PR should have alt text for accessibility.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add documentation for two new blockchain networks: Sonic (L1) and Soneium (L2), expanding the platform's supported blockchain infrastructure.
New Features:
Documentation: