-
Notifications
You must be signed in to change notification settings - Fork 0
fix: deployment plan #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe document on deployment plans for SettleMint has been significantly transformed to include structured metadata and detailed guidance on deployment strategies. Key updates encompass sections on infrastructure types, cloud providers, resource packs, and recommended setups, providing users with essential information for making informed deployment decisions. Changes
Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Note Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login. TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reviewer's Guide by SourceryThis pull request updates the documentation for deployment plans in the SettleMint platform. It adds detailed information about infrastructure types, cloud providers and regions, and resource packs. The changes provide a comprehensive overview of deployment options and recommendations for different use cases. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bl0up - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Your trial expires on September 2, 2024. Please upgrade to continue using Sourcery ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.| - **Shared** - This is typically the most cost-effective deployment configuration. Resources are deployed in a shared cluster. The performance will vary based on the demand from other services sharing the infrastructure. This configuration is like living on an island with other inhabitants with whom you need to share limited resources. | ||
| - **Dedicated** - This configuration offers the highest specifications without requiring additional technical overhead. Your service runs on its own exclusively-used cloud infrastructure, meaning it can't be impacted by others. To continue the metaphor, with this configuration you choose the size of the island based on your needs, and you don't share its resources with anyone else. | ||
|
|
||
| **On-premise** and **Bring Your Own Cloud (BYOC)** are also supported. Feel free [contact us](mailto:support@settlemint.com) to discuss these options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider adding links to separate pages for On-premise and BYOC options
This would provide users with more information without cluttering the main document.
**On-premise** and **[Bring Your Own Cloud (BYOC)](byoc.md)** are also supported. For more details, see our [On-premise deployment](on-premise.md) page. Feel free to [contact us](mailto:support@settlemint.com) to discuss these options further.
|
|
||
| ## Cloud provider and region | ||
|
|
||
| We offer you the flexibility to deploy your services in the cloud of your choice, and easily build cross-cloud provider and cross-geographical region networks. All leading cloud providers are supported and we are continously working on adding support for more regions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Fix typo: 'continously' should be 'continuously'
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Summary by Sourcery
Add comprehensive documentation for deployment plans, outlining infrastructure types, cloud provider choices, and resource allocation options for different service needs.
Documentation:
Summary by CodeRabbit