Skip to content

Conversation

@roderik
Copy link
Member

@roderik roderik commented Sep 10, 2025

Modified the scripts in package.json to ensure compatibility with the latest bun and next versions, including changes to the build, dev, and start commands. Additionally, adjusted the clean script to enhance file removal processes.

Summary by Sourcery

Improve package.json scripts for bun and Next.js compatibility and tweak global CSS.

Enhancements:

  • Set max-width to 100% on #nd-page in global CSS

Build:

  • Revise clean script to remove lock files and run bun install
  • Add --turbopack flag to next build and dev commands

Modified the scripts in package.json to ensure compatibility with the latest bun and next versions, including changes to the build, dev, and start commands. Additionally, adjusted the clean script to enhance file removal processes.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 10, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @roderik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing development workflow efficiency and improving UI responsiveness. It updates key build and development scripts to leverage modern tooling features and introduces a minor CSS adjustment to ensure better layout consistency.

Highlights

  • Script Updates: The build and dev scripts in package.json have been updated to utilize --turbopack for potentially faster compilation and development.
  • UI Styling Adjustment: The #nd-page style in src/app/global.css now includes max-width: 100% to ensure proper rendering across different screen sizes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the qa:running QA workflow is currently running label Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

To view in Slack, search for: 1757483933.931329

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The clean script now includes bun install which mixes cleaning with installation—consider splitting these into separate scripts to keep responsibilities clear.
  • You’ve added --turbopack flags to build and dev but not start—ensure consistency or confirm that start doesn’t require the flag.
  • The max-width:100% on #nd-page may override intended layout constraints; verify this change works across all breakpoints.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The clean script now includes bun install which mixes cleaning with installation—consider splitting these into separate scripts to keep responsibilities clear.
- You’ve added --turbopack flags to build and dev but not start—ensure consistency or confirm that start doesn’t require the flag.
- The max-width:100% on #nd-page may override intended layout constraints; verify this change works across all breakpoints.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package.json scripts to use Turbopack for both development and production builds, and adds a CSS rule to global.css. While using Turbopack for development is a good performance enhancement, using it for production builds is still considered beta and may lead to instability. I have suggested removing the --turbopack flag from the build script to ensure production stability. The CSS change seems to be a straightforward layout improvement.

package.json Outdated
"clean": "git clean -fdX -e '.env' -e '.env.*' -e '!.env' -e '!.env.*' && find . -type f \\( -name 'pnpm-lock.yaml' -o -name 'package-lock.json' -o -name 'yarn.lock' -o -name 'bun.lockb' -o -name 'bun.lock' \\) -exec rm -f {} + && bun install",
"build": "bun generate-sdk-docs && next build",
"dev": "bun generate-sdk-docs && next dev",
"build": "bun generate-sdk-docs && next build --turbopack",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using --turbopack for production builds (next build) is currently in beta and may not be stable. It is generally recommended to use experimental features like this for development environments only, to avoid potential issues in production. Consider removing the --turbopack flag from the build script to ensure a stable production build.

Suggested change
"build": "bun generate-sdk-docs && next build --turbopack",
"build": "bun generate-sdk-docs && next build",

@dosubot dosubot bot added the chore Maintenance tasks label Sep 10, 2025
@github-actions github-actions bot added the status:ready-for-review Pull request is ready for review label Sep 10, 2025
@dosubot
Copy link

dosubot bot commented Sep 10, 2025

Related Documentation

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@github-actions github-actions bot added qa:failed QA workflow failed and removed qa:running QA workflow is currently running labels Sep 10, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

package.json Outdated
Comment on lines 7 to 8
"build": "bun generate-sdk-docs && next build --turbopack",
"dev": "bun generate-sdk-docs && next dev --turbopack",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Use current Next.js flag for Turbopack builds

The build and dev scripts now call next build --turbopack and next dev --turbopack, but the Next 15 CLI bundled in this repo exposes the Turbopack switch as --turbo (the --turbopack alias was removed). When these scripts run, Next exits with “Unknown or unexpected option: --turbopack”, preventing both bun run build and bun run dev from starting at all. Switching the flag to --turbo restores compatibility with Next 15.5.2.

Useful? React with 👍 / 👎.

Updated the package.json scripts to improve compatibility with bun and next, including modifications to the clean, build, dev, and start commands. The clean script was enhanced for better file management.
@github-actions github-actions bot added qa:running QA workflow is currently running qa:success QA workflow passed successfully and removed qa:failed QA workflow failed qa:running QA workflow is currently running labels Sep 10, 2025
@roderik roderik merged commit 69d03c4 into main Sep 10, 2025
8 checks passed
@roderik roderik deleted the feat/rebuild-fuma branch September 10, 2025 06:10
@dosubot
Copy link

dosubot bot commented Sep 10, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@github-actions github-actions bot added status:merged Pull request has been merged and removed status:ready-for-review Pull request is ready for review labels Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance tasks qa:success QA workflow passed successfully size:XS This PR changes 0-9 lines, ignoring generated files. status:merged Pull request has been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant