Skip to content

chore(deps): update ghcr.io/settlemint/codestudio-asset-tokenization-kit docker tag to v2.0.0-main.141891 #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Nov 29, 2025
Merged

chore(deps): update ghcr.io/settlemint/codestudio-asset-tokenization-kit docker tag to v2.0.0-main.141891 #956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

services:
asset-tokenization-kit-content:
image: ghcr.io/settlemint/codestudio-asset-tokenization-kit:2.0.0-main.141841
image: ghcr.io/settlemint/codestudio-asset-tokenization-kit:2.0.0-main.141891
Copy link

@sentry sentry bot Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Race condition in QA workflow causes silent documentation build failures due to detached docker-compose.
Severity: MEDIUM | Confidence: Medium

🔍 Detailed Analysis

The GitHub QA workflow launches a docker-compose service in detached mode (-d) to generate documentation. It does not wait for the container to complete its operations, nor does it check the exit status of the docker-compose command. Immediately after, bun run build executes, which includes next build. If the updated Docker image (version 141891) introduces breaking changes that cause the documentation generation within the container to fail (e.g., cp command fails), the workflow proceeds unaware. This creates a race condition where next build may run before documentation files are copied, leading to a successful build but with missing or incomplete documentation for the asset-tokenization-kit.

💡 Suggested Fix

Modify the GitHub QA workflow to wait for the docker-compose service to complete and check its exit status before proceeding with bun run build. Consider using docker compose up --wait or similar mechanisms.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docker-compose.yml#L4

Potential issue: The GitHub QA workflow launches a `docker-compose` service in detached
mode (`-d`) to generate documentation. It does not wait for the container to complete
its operations, nor does it check the exit status of the `docker-compose` command.
Immediately after, `bun run build` executes, which includes `next build`. If the updated
Docker image (version 141891) introduces breaking changes that cause the documentation
generation within the container to fail (e.g., `cp` command fails), the workflow
proceeds unaware. This creates a race condition where `next build` may run before
documentation files are copied, leading to a successful build but with missing or
incomplete documentation for the asset-tokenization-kit.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4353236

container_name: asset-tokenization-kit-content
volumes:
- ./content/docs/asset-tokenization-kit:/dest
Expand Down
Loading