Skip to content

Conversation

@snigdha920
Copy link
Contributor

@snigdha920 snigdha920 commented Nov 29, 2024

Summary by Sourcery

Documentation:

  • Update documentation to include instructions for using AMD-based container images in custom deployments.

@linear
Copy link

linear bot commented Nov 29, 2024

CUS-534 Document platform error for image pull failure in custom deployment

indd it is the platform which is incorrect, I'll atleast add it in the docs here https://console.settlemint.com/documentation/docs/using-platform/custom-deployment/#limitations-and-considerations:

[custom-deployment][ErrImagePull] rpc error: code = NotFound desc = failed to pull and unpack image "http://ghcr.io/settlemintindia/bond-fractionalization-app:latest|ghcr.io/settlemintindia/bond-fractionalization-app:latest": no match for platform in manifest: not found

@snigdha920 snigdha920 requested a review from janb87 November 29, 2024 11:54
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 29, 2024

Reviewer's Guide by Sourcery

This PR updates the custom deployment documentation to improve formatting and adds important information about AMD-based container image requirements. The changes primarily focus on enhancing readability through better spacing and adding a new limitation regarding AMD architecture support.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new requirement for AMD-based container images
  • Added new limitation section about AMD architecture support
  • Specified that the platform only supports AMD-based container images
docs/using-platform/24_custom-deployment.md
Improved document formatting and readability
  • Added consistent spacing between list items
  • Fixed line wrapping for better readability
  • Improved visual separation of sections
docs/using-platform/24_custom-deployment.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the feat New feature label Nov 29, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @snigdha920 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@snigdha920 snigdha920 merged commit aa3f862 into main Nov 29, 2024
3 checks passed
@snigdha920 snigdha920 deleted the snigdha/cus-534-document-platform-error-for-image-pull-failure-in-custom branch November 29, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants