Conversation
|
To view in Slack, search for: 1777040484.653779 |
github-actions
Bot
added
qa:success
github-actions
Bot
added
qa:running
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for generating RPC nodes in the bootstrap command, including new CLI options for node counts and naming prefixes. The output logic for screen, file, and Kubernetes targets has been updated to include RPC node artifacts, and default naming for validator nodes was modified. A review comment suggests allowing independent port configuration for RPC nodes in the future to support more complex network topologies.
| const rpcStaticNodes = createStaticNodeEntries(rpcNodes, { | ||
| namespace: staticNodeNamespaceOption, | ||
| domain: staticNodeDomainOption, | ||
| serviceName: rpcNodeServiceName, | ||
| podPrefix: rpcNodePodPrefix, | ||
| port: staticNodePortOption ?? DEFAULT_STATIC_NODE_PORT, | ||
| discoveryPort: staticNodeDiscoveryPortOption ?? DEFAULT_STATIC_NODE_PORT, | ||
| }); |
There was a problem hiding this comment.
The logic for creating RPC static node entries uses the same port and discoveryPort as validators. While this is generally acceptable for separate pods in a Kubernetes environment, it might be beneficial to allow independent port configuration for RPC nodes in the future to support more complex network topologies.
github-actions
Bot
added
qa:success
github-actions
Bot
added
status:merged
1 participant
No description provided.