fix: add includePredeployedContracts option for deploying a new network #1284
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @janb87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration option to control the inclusion of predeployed contracts when provisioning new blockchain networks. This enhancement is primarily aimed at streamlining and stabilizing the setup of test environments, ensuring that newly created networks are properly configured for subsequent automated tests.
Highlights
- New includePredeployedContracts Option: Introduced a new --includePredeployedContracts option for the
besu createCLI command and a corresponding $includePredeployedContracts argument for thecreateBlockchainNetworkGraphQL mutation. - Enhanced Test Environment Setup: This new option facilitates the creation of blockchain networks with necessary predeployed contracts, specifically addressing requirements for automated testing environments and improving test reliability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
To view in Slack, search for: 1756989923.569979 |
github-actions
bot
added
the
status:ready-for-review
There was a problem hiding this comment.
Code Review
This pull request introduces an includePredeployedContracts option for creating a new Besu network, which is a necessary fix for the test suite. The changes span across the CLI command, the GraphQL mutation, and test scripts. While the intent is clear and the GraphQL and test script modifications are correct, there is a critical issue in the implementation of the new CLI option. It incorrectly uses a number parser for what should be a boolean flag, which will cause runtime failures. The other changes, such as adding retries and timeouts to tests, are good improvements for stability.
sdk/cli/src/commands/platform/blockchain-network/besu/create.ts
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
github-actions
bot
added
qa:success
github-actions
bot
added
qa:running
📦 Packages
|
github-actions
bot
added
qa:success
github-actions
bot
added
status:merged
…rk (#1284) Tests require the predeployed contracts. Caused by https://github.com/settlemint/btp/pull/8354/files
Tests require the predeployed contracts. Caused by https://github.com/settlemint/btp/pull/8354/files