Skip to content

Conversation

@janb87
Copy link
Contributor

@janb87 janb87 commented Sep 19, 2025

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @janb87, you have reached your weekly rate limit of 1500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @janb87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the GraphQL API by introducing new fields for blockchain network configurations and multi-service integrations, as well as improving the flexibility of workspace invitation acceptance. It also includes updates to the corresponding TypeScript type definitions and minor adjustments to end-to-end tests for increased stability.

Highlights

  • GraphQL Schema Updates: Added a new genesisArtifactsTag field to both BesuIbftv2BlockchainNetwork and BesuQBFTBlockchainNetwork types in the GraphQL schema. This field stores the version tag for network-wide pinning of genesis artifacts.
  • Multi-Service Integration Configuration: Introduced a preloadDatabaseSchema boolean field to the CreateMultiServiceIntegrationArgs input type, allowing for more granular control during service creation.
  • Workspace Invitation Enhancement: The acceptWorkspaceInvite mutation was updated to support accepting multiple invitations simultaneously by adding an optional inviteIds array argument, alongside the existing single inviteId.
  • TypeScript Type Definition Synchronization: The TypeScript type definitions in graphql-env.d.ts were updated to reflect all changes made to the GraphQL schema, ensuring type safety and consistency.
  • E2E Test Robustness: Modified end-to-end tests for platform service listing to handle potentially undefined environment variables more gracefully by using the nullish coalescing operator and adding toBeDefined() checks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the qa:running QA workflow is currently running label Sep 19, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

To view in Slack, search for: 1758267763.873589

@github-actions github-actions bot added the status:ready-for-review Pull request is ready for review label Sep 19, 2025
@dosubot dosubot bot added the fix Bug fix label Sep 19, 2025
@dosubot
Copy link

dosubot bot commented Sep 19, 2025

Related Documentation

Checked 1 published document(s). No updates required.

You have 7 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

📦 Packages

Package NPM Docker
SDK Cli @settlemint/sdk-cli@2.6.2-pr47c5be9d
SDK The Graph @settlemint/sdk-thegraph@2.6.2-pr47c5be9d
SDK Portal @settlemint/sdk-portal@2.6.2-pr47c5be9d
SDK Hasura @settlemint/sdk-hasura@2.6.2-pr47c5be9d
SDK JS @settlemint/sdk-js@2.6.2-pr47c5be9d
SDK Utils @settlemint/sdk-utils@2.6.2-pr47c5be9d
SDK Next @settlemint/sdk-next@2.6.2-pr47c5be9d
SDK Minio @settlemint/sdk-minio@2.6.2-pr47c5be9d
SDK IPFS @settlemint/sdk-ipfs@2.6.2-pr47c5be9d
SDK Blockscout @settlemint/sdk-blockscout@2.6.2-pr47c5be9d
SDK MCP @settlemint/sdk-mcp@2.6.2-pr47c5be9d
SDK Viem @settlemint/sdk-viem@2.6.2-pr47c5be9d
SDK EAS @settlemint/sdk-eas@2.6.2-pr47c5be9d

@github-actions github-actions bot added qa:success QA workflow passed successfully and removed qa:running QA workflow is currently running labels Sep 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GraphQL schema, most notably by modifying the acceptWorkspaceInvite mutation to handle single or multiple invitations. While this adds flexibility, making both inviteId and inviteIds optional introduces ambiguity. I've suggested a more robust API design using an input object with the @oneOf directive to ensure either a single ID or a list of IDs is provided, but not both or neither. Other changes include adding new optional fields to support genesis artifacts and database preloading, and improving the robustness of e2e tests, which are positive changes.

@janb87 janb87 merged commit 3d09571 into main Sep 19, 2025
16 checks passed
@janb87 janb87 deleted the jan/fix-e2e-types branch September 19, 2025 07:56
@github-actions github-actions bot added status:merged Pull request has been merged and removed status:ready-for-review Pull request is ready for review labels Sep 19, 2025
@dosubot
Copy link

dosubot bot commented Sep 19, 2025

Documentation Updates

Checked 1 published document(s). No updates required.

You have 7 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix qa:success QA workflow passed successfully size:M This PR changes 30-99 lines, ignoring generated files. status:merged Pull request has been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants