-
Notifications
You must be signed in to change notification settings - Fork 2
fix: e2e types #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e types #1316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of ChangesHello @janb87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the GraphQL API by introducing new fields for blockchain network configurations and multi-service integrations, as well as improving the flexibility of workspace invitation acceptance. It also includes updates to the corresponding TypeScript type definitions and minor adjustments to end-to-end tests for increased stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
To view in Slack, search for: 1758267763.873589 |
|
Related Documentation Checked 1 published document(s). No updates required. You have 7 draft document(s). Publish docs to keep them always up-to-date |
📦 Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the GraphQL schema, most notably by modifying the acceptWorkspaceInvite mutation to handle single or multiple invitations. While this adds flexibility, making both inviteId and inviteIds optional introduces ambiguity. I've suggested a more robust API design using an input object with the @oneOf directive to ensure either a single ID or a list of IDs is provided, but not both or neither. Other changes include adding new optional fields to support genesis artifacts and database preloading, and improving the robustness of e2e tests, which are positive changes.
|
Documentation Updates Checked 1 published document(s). No updates required. You have 7 draft document(s). Publish docs to keep them always up-to-date |
No description provided.