-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependency @inquirer/core to v10.3.0 #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Packages
|
| "docs": "bun scripts/create-docs.ts", | ||
| "prepack": "cp ../../LICENSE ." | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: Due to a version mismatch in @inquirer/core, instanceof checks for prompt cancellation errors fail, leading to incorrect error handling.
-
Description: The build process bundles
@inquirer/core@10.3.0but leaves other@inquirer/*packages as external, which then resolve to@inquirer/core@10.2.2from the lockfile. When a user cancels a prompt (e.g., with Ctrl+C), an error likeExitPromptErroris thrown by a package using v10.2.2. The main error handler insdk/cli/src/commands/index.tscheckserror instanceof ExitPromptErrorusing the class from the bundled v10.3.0. This check fails because the error instance and the class constructor are from different module versions. Consequently, instead of a graceful exit, the CLI reports an "Unknown error" and exits with code 1. -
Suggested fix: Ensure all
@inquirer/*packages, including@inquirer/core, are treated consistently in the build configuration. Either bundle all of them or mark all of them as external intsdown.config.tsto prevent version mismatches. Aligning all@inquirer/*dependencies to the same version inpackage.jsonis also necessary to ensureinstanceofchecks work correctly.
severity: 0.85, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="bun.lock">
<violation number="1" location="bun.lock:51">
Updating `@inquirer/core` in isolation breaks error handling for prompts. Other `@inquirer/*` packages still use an older version, causing `instanceof` checks on error types to fail due to version mismatch. This will treat user-cancelled prompts as crashes.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "dependencies": { | ||
| "@gql.tada/cli-utils": "1.7.1", | ||
| "@inquirer/core": "10.2.2", | ||
| "@inquirer/core": "10.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating @inquirer/core in isolation breaks error handling for prompts. Other @inquirer/* packages still use an older version, causing instanceof checks on error types to fail due to version mismatch. This will treat user-cancelled prompts as crashes.
Prompt for AI agents
Address the following comment on bun.lock at line 51:
<comment>Updating `@inquirer/core` in isolation breaks error handling for prompts. Other `@inquirer/*` packages still use an older version, causing `instanceof` checks on error types to fail due to version mismatch. This will treat user-cancelled prompts as crashes.</comment>
<file context>
@@ -48,7 +48,7 @@
"dependencies": {
"@gql.tada/cli-utils": "1.7.1",
- "@inquirer/core": "10.2.2",
+ "@inquirer/core": "10.3.0",
"node-fetch-native": "1.6.7",
"zod": "^4",
</file context>
7c495d8 to
72ccd0d
Compare
72ccd0d to
8dcca57
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
8dcca57 to
8dc7665
Compare
This PR contains the following updates:
10.2.2->10.3.0Release Notes
SBoudrias/Inquirer.js (@inquirer/core)
v10.3.0Compare Source
isUpKey/isDownKeynow accepts a second parameterskeybindings: ['vim', 'emacs']that'll match up/down actions done with the keybindings specific to those editors.Configuration
📅 Schedule: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.