Skip to content

fix: broken e2e tests #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

fix: broken e2e tests #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe238e5
fix: broken e2e tests
janb87 Oct 28, 2025
245d6fc
r
janb87 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/create-new-settlemint-project.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe("Setup a project on the SettleMint platform using the SDK", () => {
await updatePackageJsonToUseLinkedDependencies(dAppDir);
await updatePackageJsonToUseLinkedDependencies(contractsDir);
await updatePackageJsonToUseLinkedDependencies(subgraphDir);
await $`bun install --no-cache`.cwd(projectDir).env(env);
await $`bun install --no-cache --linker=hoisted`.cwd(projectDir).env(env);
});

test("Connect to platform", async () => {
Expand Down
2 changes: 1 addition & 1 deletion test/create-new-standalone-project.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe("Setup a project on a standalone environment using the SDK", () => {
await updatePackageJsonToUseLinkedDependencies(dAppDir);
await updatePackageJsonToUseLinkedDependencies(contractsDir);
await updatePackageJsonToUseLinkedDependencies(subgraphDir);
await $`bun install --no-cache`.cwd(projectDir).env(env);
await $`bun install --no-cache --linker=hoisted`.cwd(projectDir).env(env);
});

test("Connect to standalone environment", async () => {
Expand Down
7 changes: 6 additions & 1 deletion test/restart-resources.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { loadEnv } from "@settlemint/sdk-utils/environment";
import { fetchWithRetry } from "@settlemint/sdk-utils/http";
import { NODE_NAME_3_WITHOUT_PK } from "./constants/test-resources";
import { forceExitAllCommands, runCommand } from "./utils/run-command";
import { findBlockchainNodeByName } from "./utils/test-resources";

const COMMAND_TEST_SCOPE = __filename;

Expand All @@ -14,11 +15,15 @@ afterEach(() => {

describe("Restart platform resources using the SDK", () => {
test("Restart blockchain node on the platform", async () => {
const blockchainNode = await findBlockchainNodeByName(NODE_NAME_3_WITHOUT_PK);
if (!blockchainNode) {
throw new Error(`Blockchain node ${NODE_NAME_3_WITHOUT_PK} not found`);
}
const { output } = await runCommand(COMMAND_TEST_SCOPE, [
"platform",
"restart",
"blockchain-node",
NODE_NAME_3_WITHOUT_PK,
blockchainNode.uniqueName,
Copy link

@cursor cursor bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Name Mismatch in Restart Command Output

The restart command now uses blockchainNode.uniqueName, but the test's output assertion still expects the hardcoded NODE_NAME_3_WITHOUT_PK. If these names differ, the test will fail because the output message will contain the uniqueName.

Fix in Cursor Fix in Web

"--wait",
"--accept-defaults",
]).result;
Expand Down
Loading