Skip to content

docs: Update optimisation to keep using eGlow instead of removing it#199

Merged
goosBanny merged 2 commits intosetupmd:v3from
SlyOtters:patch-1
Mar 7, 2025
Merged

docs: Update optimisation to keep using eGlow instead of removing it#199
goosBanny merged 2 commits intosetupmd:v3from
SlyOtters:patch-1

Conversation

@SlyOtters
Copy link
Contributor

Description

Hello, as the current developer of eGlow I'd like to propose a change in the documentation as currently it states to remove eGlow while it can be modified to disable the features. Although that this will cause incorrect glow colors unless TAB groups/users are reconfigured (which I also included). I think it's better to explain how to disable these parts in eGlow rather than saying to remove it fully.

Resolved issues

NA

Before submitting the PR, please take the following into consideration

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • [ X ] Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • [ X ] The description should clearly illustrate what problems it solves.
  • [ X ] Ensure that the commit messages follow our guidelines.
  • [ X ] Resolve merge conflicts (if any).
  • [ X ] Make sure that the current branch is upto date with the main branch.

@ukdaaan
Copy link
Collaborator

ukdaaan commented Mar 7, 2025

@goosBanny Can you have a little look over this and give it the thumbs up

@ukdaaan ukdaaan removed their assignment Mar 7, 2025
@goosBanny goosBanny self-requested a review March 7, 2025 17:50
Copy link
Contributor

@goosBanny goosBanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goosBanny goosBanny merged commit dde8f99 into setupmd:v3 Mar 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments