Skip to content

[BEAM-5160] Failing ReduceWindow test fix#20

Merged
VaclavPlajt merged 0 commit intovasek/docs-improvementsfrom
vasek/reduce-window-test-fix
Aug 21, 2018
Merged

[BEAM-5160] Failing ReduceWindow test fix#20
VaclavPlajt merged 0 commit intovasek/docs-improvementsfrom
vasek/reduce-window-test-fix

Conversation

@VaclavPlajt
Copy link

Test fixed. Unwanted conditional translation of ReduceWindow removed.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

Copy link

@mareksimunek mareksimunek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VaclavPlajt VaclavPlajt force-pushed the vasek/docs-improvements branch from 62e78a1 to 336ce8e Compare August 20, 2018 14:14
@VaclavPlajt VaclavPlajt merged this pull request into vasek/docs-improvements Aug 21, 2018
@VaclavPlajt VaclavPlajt deleted the vasek/reduce-window-test-fix branch August 21, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants