Skip to content

Environment + Packaging#1

Merged
bephrem1 merged 4 commits into
mainfrom
bephrem/foundation
Jun 24, 2024
Merged

Environment + Packaging#1
bephrem1 merged 4 commits into
mainfrom
bephrem/foundation

Conversation

@bephrem1
Copy link
Copy Markdown
Contributor

@bephrem1 bephrem1 commented Jun 23, 2024

  • .env.development + .env.production (only 2 environments necessary)
  • move source under /src
  • give each command a file in /src/lib
  • url helpers / source-of-truth
  • development-only attached commands

Invisible Changes

  • Update readme with end-user install details

Still need to ensure production build uses production environment, for now defaults to development configs

@bephrem1 bephrem1 requested a review from Flaque June 23, 2024 23:44
Copy link
Copy Markdown
Member

@Flaque Flaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow!

I think dist/cli.js is still included in this, so I request we remove it before this is merged though

@bephrem1 bephrem1 merged commit 8615f04 into main Jun 24, 2024
@bephrem1 bephrem1 deleted the bephrem/foundation branch June 24, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants