ssh add --init flag#26
Merged
Merged
Conversation
coffinsfcompute
force-pushed
the
coffin/ssh_magic_setup
branch
from
3c5728a to
ef1ad03
Compare
coffinsfcompute
force-pushed
the
coffin/ssh_magic_setup
branch
from
ef1ad03 to
4368076
Compare
Flaque
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative setup path to using
--addso that a customer can just run:and it should just always work. I hope that the backend deduplicates ssh public keys as otherwise I can easily see customers running
--initmore than once and having the backend receive another request to add it.I was slightly unsure about the expected handling of errors in terms of what should be logged, thrown, etc. but I have tested this code somewhat thoroughly manually and it seems to work properly from everything that I can observe. I probably made it more robust than necessary, but also I really don't want to debug weird edge cases of this command failing while a customer is stressed and unable to ssh into their machines. I was wondering if should update the
Warning: failed finding default ssh keys (checking hardcoded list)to request them to email us? It would almost certainly indicate a bug.