Skip to content

feat(nodes): accept undocumented --enable-infiniband flag on sf nodes create #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmachirality wants to merge 1 commit into from
Closed

feat(nodes): accept undocumented --enable-infiniband flag on sf nodes create #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/lib/nodes/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@ const create = new Command("create")
"ID of the VM image to boot on the nodes. View available images with `sf node images list`.",
),
)
.addOption(
// Hidden experimental flag. Requires the (account, instance SKU) pair to
// be in the IB whitelist server-side; otherwise the request is rejected
// with 403. Kept undocumented while the field is in preview.
new Option(
"--enable-infiniband",
"Enable InfiniBand on the nodes (experimental, undocumented).",
).hideHelp(),
)
.addOption(yesOption)
.addOption(jsonOption)
.hook("preAction", (command) => {
Expand Down Expand Up @@ -274,6 +283,7 @@ async function createNodesAction(
cloud_init_user_data: encodedUserData,
image_id: options.image,
node_type: isReserved ? "reserved" : "autoreserved",
...(options.enableInfiniband ? { _preview_enable_infiniband: true } : {}),
};

if (isReserved) {
Expand Down