Skip to content

parse duration as seconds, not ms #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sladuca merged 2 commits into from
Aug 14, 2024
Merged

parse duration as seconds, not ms #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a374a
parseDuration as s, not ms
Sladuca Aug 14, 2024
a0a975a
bun i
Sladuca Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
7 changes: 4 additions & 3 deletions src/lib/buy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ async function placeBuyOrder(props: PlaceBuyOrderArguments) {
const { type, duration, price, quantity, start } = props;

const orderQuantity = quantity ? Number(quantity) : 1;
const durationMs = parseDuration(duration);
if (!durationMs) {
const durationSecs = parseDuration(duration, "s");
if (!durationSecs) {
return logAndQuit("Invalid duration");
}

const startDate = start ? chrono.parseDate(start) : new Date();
if (!startDate) {
return logAndQuit("Invalid start date");
Expand All @@ -100,7 +101,7 @@ async function placeBuyOrder(props: PlaceBuyOrderArguments) {
quantity: orderQuantity,
price: priceToCenticents(price),
instance_type: type,
duration: durationMs / 1000, // Convert milliseconds to seconds
duration: durationSecs,
start_at: startDate.toISOString(),
};

Expand Down
6 changes: 3 additions & 3 deletions src/lib/sell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ async function placeSellOrder(options: {
}

const flags = options.flags || {};
const durationMs = parseDuration(options.duration);
if (!durationMs) {
const durationSecs = parseDuration(options.duration, "s");
if (!durationSecs) {
return logAndQuit("Invalid duration");
}
const startDate = options.start
Expand All @@ -68,7 +68,7 @@ async function placeSellOrder(options: {
quantity: forceAsNumber(options.quantity),
price: priceToCenticents(options.price),
contract_id: options.contractId,
duration: durationMs,
duration: durationSecs,
start_at: startDate.toISOString(),
...flags,
};
Expand Down