First version of reverse oauth

[ys]

Still a lot to do.
I made it like a cowboy.
Now I need to clean that up, and test it.
The problem also is that it's not json unless for the errors...

[sferik]

Any particular reason to put this in its own module vs. adding it to the Twitter::REST::API::OAuth module?

[ys]

Not really, at the beginning it was a lot noisier:)
I Will refactor that

[sferik]

Please use Ruby 1.8.7-compatible hash syntax.

[sferik]

Are you planning to do any more work on this or should I merge it as-is and clean up the specs myself?

[ys]

I plane to do it soon! Sorry it has been a very busy month!

Yannick

On 29 Sep 2013, at 15:23, Erik Michaels-Ober notifications@github.com wrote:

Are you planning to do any more work on this or should I merge it as-is and clean up the specs myself?

—
Reply to this email directly or view it on GitHub.

[ys]

Will try to do it tonight!

Yannick

On 29 Sep 2013, at 15:23, Erik Michaels-Ober notifications@github.com wrote:

Are you planning to do any more work on this or should I merge it as-is and clean up the specs myself?

—
Reply to this email directly or view it on GitHub.

[sferik]

Awesome!

[ys]

New specs and error parser for twitter error responses only

[coveralls]

Coverage increased (+0.17%) when pulling 7b9c3ea on ys:reverse_auth into da2280f on sferik:master.

[sferik]

This class could inherit from Twitter::REST::Response::ParseJson and just overwrite #on_complete, no?

[ys]

Yep better idea!

Yannick

On 29 Sep 2013, at 21:44, Erik Michaels-Ober notifications@github.com wrote:

In lib/twitter/rest/response/parse_error_json.rb:

@@ -0,0 +1,27 @@
+require 'faraday'
+require 'json'
+
+module Twitter

• module REST
• module Response

•  class ParseErrorJson < Faraday::Response::Middleware
  

  This class could inherit from Twitter::REST::Response::ParseJson and just overwrite #on_complete, no?

—
Reply to this email directly or view it on GitHub.

[coveralls]

Coverage increased (+0.0%) when pulling 6b3cf22 on ys:reverse_auth into da2280f on sferik:master.

[sferik]

Looks good now. Planning to ship 5.0.0.rc.2 shortly.