refactor(config): remove unused buffer configuration parameter #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the buffer field from OutputConfig as it was parsed but never actually used in the processing code. This prevents user confusion from setting buffer values that have no effect. Changes: - Remove Buffer field from OutputConfig struct - Remove buffer validation logic - Remove ErrInvalidBufferMode error type - Remove buffer from default configuration - Remove buffer from example YAML files - Remove buffer-related tests - Simplify output validation to only check format Breaking change: Users with "buffer:" in config files will get YAML unknown field warnings. This is acceptable since the field never actually worked and this is a pre-1.0 project. Default behavior (line buffering) remains unchanged. Closes #16
11 tasks
sgaunet
deleted the
16-implement-or-remove-incomplete-buffering-feature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the buffer field from OutputConfig as it was parsed but never
actually used in the processing code. This prevents user confusion from
setting buffer values that have no effect.
Changes:
Breaking change: Users with "buffer:" in config files will get YAML
unknown field warnings. This is acceptable since the field never
actually worked and this is a pre-1.0 project.
Default behavior (line buffering) remains unchanged.
Closes #16