Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 2, 2025

Pull request

Related issue

Resolve #101 @handje

Motivation and context

  • 상세페이지 주식 레이아웃

Solution

  • 주식 정보와 차트 구역 분리
  • 주식 차트 container 는 resizable로 구현
  • 배경색은 삭제될 예정이라 기존 스타일대로 텍스트를 검정색으로 구현하여 흐리게 보일 수 있습니다.

How has this been tested

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje requested a review from KimKyuHoi February 2, 2025 15:23
@handje handje self-assigned this Feb 2, 2025
@handje handje added ✨ Feature 기능 추가 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 무조건 스프린트내에 해야하는 것들 labels Feb 2, 2025
@handje handje added this to the 주톡피아 마일스톤 1 milestone Feb 2, 2025
@handje
Copy link
Collaborator Author

handje commented Feb 3, 2025

@KimKyuHoi 말씀해주신 부분 스타일링 수정 및 불필요한 태그 삭제했습니다!

@handje handje requested a review from KimKyuHoi February 3, 2025 02:47
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@handje handje merged commit 075bcdb into dev Feb 3, 2025
2 of 3 checks passed
@handje handje deleted the fe-feat/stock-detail-layout branch February 7, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 ✨ Feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

주식상세 레이아웃

3 participants