added sglang arguments #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We previously hard-coded some of the sglang arguments such as mem-fraction-static, which makes specforge inflexible in tuning performance, we should add some arguments for sglang.
Modifications
I have collated the sglang arguments in
specforge.args. The reason for not usingsglang.srt.server_args.ServerArgs.add_cli_argsdirectly is that we don't actually need SGLang's all arguments, we only need those that are relevant to parallelism and prefill optimization. Adding all args from sglang will cause confusion as the other arguments do not take effect at all. sglang 0.5.4 has some bugs so I updated it to 0.5.5 as well.Meanwhile, for simplicity, I have also collated tracker args in
specforge.args.Related Issues
Accuracy Test
Benchmark & Profiling
Checklist