-
Notifications
You must be signed in to change notification settings - Fork 132
added autoflakes pre-commit hook #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @FrankLeeeee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the "autoflake" tool into the pre-commit configuration, which will automatically identify and remove unused import statements in Python files. Concurrently, it cleans up existing unused imports across several Python files, enhancing the overall code quality, reducing bundle size, and making the codebase easier to maintain. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the autoflake pre-commit hook to automatically remove unused imports, which is a great step towards maintaining a clean codebase. The changes in the Python files reflect the application of this new hook. I've added one suggestion to enhance the autoflake configuration to also remove unused variables and expand star imports, which would further improve code quality.
07d50c3 to
18b6bfe
Compare
| @@ -1,2 +0,0 @@ | |||
| from .core import * | |||
| from .modeling import * | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this deletes too much. How do you do something like
from specforge import AutoDraftModelConfig, AutoEagle3DraftModel, OfflineEagle3Modelif __init__.py is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nbroad1881 I found this as well, I am fixing this and ensuring future changes will not break scripts in #331
Motivation
We need a pre-commit hook to clean the unused imports automatically.
Modifications
I have added the
autoflakeshook to the pre-commit config file and run it on the repo.Related Issues
Accuracy Test
Benchmark & Profiling
Checklist