Skip to content

Conversation

@FrankLeeeee
Copy link
Collaborator

@FrankLeeeee FrankLeeeee commented Nov 25, 2025

Motivation

We need a pre-commit hook to clean the unused imports automatically.

Modifications

I have added the autoflakes hook to the pre-commit config file and run it on the repo.

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @FrankLeeeee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the "autoflake" tool into the pre-commit configuration, which will automatically identify and remove unused import statements in Python files. Concurrently, it cleans up existing unused imports across several Python files, enhancing the overall code quality, reducing bundle size, and making the codebase easier to maintain.

Highlights

  • New Pre-Commit Hook: Introduced "autoflake" as a new pre-commit hook to automatically remove unused imports, ensuring cleaner and more efficient Python code.
  • Codebase Cleanup: Removed numerous unused import statements from "model_runner.py" and "patch.py" within the "specforge/modeling/target/sglang_backend" module, improving code readability and reducing potential clutter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the autoflake pre-commit hook to automatically remove unused imports, which is a great step towards maintaining a clean codebase. The changes in the Python files reflect the application of this new hook. I've added one suggestion to enhance the autoflake configuration to also remove unused variables and expand star imports, which would further improve code quality.

@FrankLeeeee FrankLeeeee force-pushed the feature/remove-unused-imports branch from 07d50c3 to 18b6bfe Compare November 25, 2025 05:37
@FrankLeeeee FrankLeeeee requested a review from zyksir as a code owner November 25, 2025 05:37
@FrankLeeeee FrankLeeeee merged commit 04a6bcf into main Nov 25, 2025
5 checks passed
@FrankLeeeee FrankLeeeee deleted the feature/remove-unused-imports branch November 25, 2025 08:51
@@ -1,2 +0,0 @@
from .core import *
from .modeling import *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deletes too much. How do you do something like

from specforge import AutoDraftModelConfig, AutoEagle3DraftModel, OfflineEagle3Model

if __init__.py is empty?

@FrankLeeeee

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbroad1881 I found this as well, I am fixing this and ensuring future changes will not break scripts in #331

@yubofredwang yubofredwang mentioned this pull request Nov 26, 2025
6 tasks
@FrankLeeeee FrankLeeeee mentioned this pull request Nov 26, 2025
6 tasks
xiaomin-D pushed a commit to eigen-ai-labs/SpecForge_public that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants