-
Notifications
You must be signed in to change notification settings - Fork 132
updated benchmark docs #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated benchmark docs #340
Conversation
Summary of ChangesHello @FrankLeeeee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the benchmark documentation and configuration to improve clarity and consistency. It standardizes the naming convention for benchmark output directories and updates various example commands to reflect current practices and correct usage, ensuring that users can more easily run and understand the benchmark processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the benchmark documentation and related scripts. The changes standardize the output directory for benchmark results to results/, fix a typo in a script argument, and update example commands to align with the latest script arguments. The changes improve consistency and correctness of the documentation. I have one suggestion regarding a removed command-line flag in an example, which could potentially cause issues for users.
* updated benchmark docs * polish * polish
Motivation
Polish the benchmark docs.
Modifications
Related Issues
Accuracy Test
Benchmark & Profiling
Checklist