Skip to content

Conversation

@FrankLeeeee
Copy link
Collaborator

@FrankLeeeee FrankLeeeee commented Dec 1, 2025

Motivation

Polish the benchmark docs.

Modifications

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @FrankLeeeee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the benchmark documentation and configuration to improve clarity and consistency. It standardizes the naming convention for benchmark output directories and updates various example commands to reflect current practices and correct usage, ensuring that users can more easily run and understand the benchmark processes.

Highlights

  • Benchmark Output Directory: The default output directory for benchmark results has been standardized from benchmark_results/ to results/ across the .gitignore file and the bench_eagle3.py script.
  • Benchmark Example Commands: The example benchmark commands in benchmarks/README.md and docs/examples/llama3-eagle3-online.md have been updated. This includes removing the explicit --output argument, correcting the script path in the documentation, adjusting the port number, removing the --trust-remote-code flag, changing the tp-size, and simplifying the --benchmark-list arguments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the benchmark documentation and related scripts. The changes standardize the output directory for benchmark results to results/, fix a typo in a script argument, and update example commands to align with the latest script arguments. The changes improve consistency and correctness of the documentation. I have one suggestion regarding a removed command-line flag in an example, which could potentially cause issues for users.

@FrankLeeeee FrankLeeeee merged commit 3e0cda0 into sgl-project:main Dec 1, 2025
2 checks passed
xiaomin-D pushed a commit to eigen-ai-labs/SpecForge_public that referenced this pull request Jan 10, 2026
* updated benchmark docs

* polish

* polish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant