-
Notifications
You must be signed in to change notification settings - Fork 132
added more benchmarks #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @FrankLeeeee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's benchmarking infrastructure by integrating a diverse set of new evaluation datasets and refining the benchmark execution process. It introduces a more flexible naming convention for benchmark results and incorporates specialized benchmarkers for tasks ranging from finance-specific question answering to multiple-choice reasoning and code generation. These additions aim to provide a more comprehensive and robust framework for assessing model performance across various domains. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new benchmarks. The implementation is mostly good, but there are a number of copy-paste errors in docstrings across the new files. I've also found a critical bug in the MMLU benchmark implementation that would lead to incorrect accuracy reporting, along with some other medium-severity issues like unused imports, leftover print statements, and non-deterministic behavior in one of the benchmarks. Please see my detailed comments for suggestions.
* added more benchmarks * polish * polish * polish
Motivation
I want to have more holistic benchmark results.
Modifications
I added more benchmarks.
Related Issues
Accuracy Test
Benchmark & Profiling
Checklist