Skip to content

Remove training-agent references and update docs#180

Merged
slin1237 merged 1 commit intosgl-project:mainfrom
carlory:t
Jul 14, 2025
Merged

Remove training-agent references and update docs#180
slin1237 merged 1 commit intosgl-project:mainfrom
carlory:t

Conversation

@carlory
Copy link
Contributor

@carlory carlory commented Jul 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix broken integration test.

Test result:

Ran 17 of 23 Specs in 8.492 seconds
SUCCESS! -- 17 Passed | 0 Failed | 6 Pending | 0 Skipped
--- PASS: TestOmeAgentIntegration (8.49s)
PASS
ok  	github.com/sgl-project/ome/tests	8.972s
✅ Integration tests passed

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@carlory carlory requested a review from slin1237 as a code owner July 14, 2025 11:09
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @carlory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant cleanup by completely removing the training-agent component from the ome-agent project. This involved updating the main README.md to reflect the current command structure and directory layout, as well as a comprehensive cleanup of the integration test suite to remove all training-agent specific tests and configurations. The changes ensure that the documentation and tests are aligned with the active components of the system, addressing a broken integration test in the process.

Highlights

  • Component Removal: I've removed all references and code related to the training-agent component from the project, indicating its deprecation or removal from the system's active features.
  • Documentation Update: The README.md has been updated to accurately reflect the current ome-agent command structure and directory layout, removing training-agent mentions and incorporating new agent types like model-metadata, serving-agent, and fine-tuned-adapter.
  • Integration Test Cleanup: The integration test suite (tests/agent_integration_test.go and tests/helpers.go) has been thoroughly cleaned up. All training-agent specific test cases, assertions, and mock configurations have been removed, which also addresses a previously broken integration test.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cleanup effort to remove references to the deprecated training-agent from documentation and tests, and to fix a broken integration test. The changes are generally good and achieve the stated goal. I've pointed out a minor formatting issue in the README.md file's directory structure diagram that should be corrected for clarity.

Comment on lines +221 to +222
│ └── serving_agent.go # Subcommand for serving sidecar agent
│ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The tree structure for the ome-agent subcommands is incorrectly formatted. Using └── for serving_agent.go implies it's the last item, but fine-tuned-adapter.go follows it. Additionally, fine-tuned-adapter.go is not correctly aligned with the other items.

To fix this, serving_agent.go should use ├── and fine-tuned-adapter.go should be the last item using └── and be properly aligned. This will make the directory structure diagram accurate and easier to read.

Suggested change
── serving_agent.go # Subcommand for serving sidecar agent
│ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter
── serving_agent.go # Subcommand for serving sidecar agent
│ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter

@slin1237 slin1237 merged commit 3e3f47c into sgl-project:main Jul 14, 2025
23 checks passed
@carlory carlory deleted the t branch July 15, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants