Remove training-agent references and update docs#180
Remove training-agent references and update docs#180slin1237 merged 1 commit intosgl-project:mainfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @carlory, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a significant cleanup by completely removing the training-agent component from the ome-agent project. This involved updating the main README.md to reflect the current command structure and directory layout, as well as a comprehensive cleanup of the integration test suite to remove all training-agent specific tests and configurations. The changes ensure that the documentation and tests are aligned with the active components of the system, addressing a broken integration test in the process.
Highlights
- Component Removal: I've removed all references and code related to the
training-agentcomponent from the project, indicating its deprecation or removal from the system's active features. - Documentation Update: The
README.mdhas been updated to accurately reflect the currentome-agentcommand structure and directory layout, removingtraining-agentmentions and incorporating new agent types likemodel-metadata,serving-agent, andfine-tuned-adapter. - Integration Test Cleanup: The integration test suite (
tests/agent_integration_test.goandtests/helpers.go) has been thoroughly cleaned up. Alltraining-agentspecific test cases, assertions, and mock configurations have been removed, which also addresses a previously broken integration test.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is a cleanup effort to remove references to the deprecated training-agent from documentation and tests, and to fix a broken integration test. The changes are generally good and achieve the stated goal. I've pointed out a minor formatting issue in the README.md file's directory structure diagram that should be corrected for clarity.
| │ └── serving_agent.go # Subcommand for serving sidecar agent | ||
| │ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter |
There was a problem hiding this comment.
The tree structure for the ome-agent subcommands is incorrectly formatted. Using └── for serving_agent.go implies it's the last item, but fine-tuned-adapter.go follows it. Additionally, fine-tuned-adapter.go is not correctly aligned with the other items.
To fix this, serving_agent.go should use ├── and fine-tuned-adapter.go should be the last item using └── and be properly aligned. This will make the directory structure diagram accurate and easier to read.
| │ └── serving_agent.go # Subcommand for serving sidecar agent | |
| │ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter | |
| │ ├── serving_agent.go # Subcommand for serving sidecar agent | |
| │ └── fine-tuned-adapter.go # Subcommand for fine-tuned adapter |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix broken integration test.
Test result:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?