[WIP] Update kimi-k2-pd-rt.yaml#203
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Atream, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the kimi-k2-pd-rt.yaml configuration file by performing a significant cleanup and streamlining of its SGLang runtime definitions. The changes primarily involve removing outdated or unnecessary SGLang-related profiling, recording, and specific runtime parameters, while introducing a new parameter for expert redundancy.
Highlights
- Configuration Cleanup: Removed various SGLang-specific volumes, volume mounts, and environment variables that were previously configured for recording and profiling.
- Runtime Argument Streamlining: Eliminated several SGLang runtime arguments, including
--context-length,--cuda-graph-bs, andSGLANG_NUM_RESERVED_DECODE_TOKENS, simplifying the command-line parameters. - Logging and Expert Redundancy Update: Replaced the
--log-level debugargument with--ep-num-redundant-experts $(PARALLELISM_SIZE)in certain runtime configurations, indicating a shift in focus from verbose logging to expert redundancy settings.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the kimi-k2-pd-rt.yaml configuration file, primarily removing debugging and profiling configurations. The review focuses on ensuring that the use of environment variables for critical parameters is well-managed and reliable.
| @@ -97,8 +87,6 @@ spec: | |||
| - prefill | |||
There was a problem hiding this comment.
Consider explicitly defining --tp-size instead of relying on the $(PARALLELISM_SIZE) variable. While using a variable is acceptable, ensure that PARALLELISM_SIZE is reliably set and managed within your deployment environment. Otherwise, the tp-size may not be what you expect, leading to unexpected behavior or performance issues. This applies to all instances where $(PARALLELISM_SIZE) is used.
| - --ep-num-redundant-experts | ||
| - $(PARALLELISM_SIZE) |
There was a problem hiding this comment.
Consider explicitly defining --ep-num-redundant-experts instead of relying on the $(PARALLELISM_SIZE) variable. While using a variable is acceptable, ensure that PARALLELISM_SIZE is reliably set and managed within your deployment environment. Otherwise, the ep-num-redundant-experts may not be what you expect, leading to unexpected behavior or performance issues. This applies to all instances where $(PARALLELISM_SIZE) is used.
| - "0.849" | ||
| - --context-length | ||
| - "2176" | ||
| - --tp-size |
There was a problem hiding this comment.
Consider explicitly defining --tp-size instead of relying on the $(PARALLELISM_SIZE) variable. While using a variable is acceptable, ensure that PARALLELISM_SIZE is reliably set and managed within your deployment environment. Otherwise, the tp-size may not be what you expect, leading to unexpected behavior or performance issues. This applies to all instances where $(PARALLELISM_SIZE) is used.
| - --ep-num-redundant-experts | ||
| - $(PARALLELISM_SIZE) |
There was a problem hiding this comment.
Consider explicitly defining --ep-num-redundant-experts instead of relying on the $(PARALLELISM_SIZE) variable. While using a variable is acceptable, ensure that PARALLELISM_SIZE is reliably set and managed within your deployment environment. Otherwise, the ep-num-redundant-experts may not be what you expect, leading to unexpected behavior or performance issues. This applies to all instances where $(PARALLELISM_SIZE) is used.
| - --ep-num-redundant-experts | ||
| - $(PARALLELISM_SIZE) |
There was a problem hiding this comment.
Consider explicitly defining --ep-num-redundant-experts instead of relying on the $(PARALLELISM_SIZE) variable. While using a variable is acceptable, ensure that PARALLELISM_SIZE is reliably set and managed within your deployment environment. Otherwise, the ep-num-redundant-experts may not be what you expect, leading to unexpected behavior or performance issues. This applies to all instances where $(PARALLELISM_SIZE) is used.
What type of PR is this?
Update kimi-k2-pd-rt.yaml
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?