feat(command): update top padding on cmdk-groups #7112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@a-jih is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Currently, pt-0 is applied to subsequent command group siblings in CommandDialog. This makes sense when one command group immediately proceeds another, maintaining even spacing between each group. However, we also end up removing the top padding on command groups that immediately proceed a separator, which makes the spacing between a group and separator visually inconsistent with that between the first group and the command input. To address this, we can update the following class to use the next- sibling combinator (+) instead of the subsequent sibling combinator (~) to target only command groups that immediately proceed another: [&_[cmdk-group]:not([hidden])_~[cmdk-group]]:pt-0 becomes: [&_[cmdk-group]:not([hidden])_+[cmdk-group]]:pt-0
Currently, pt-0 is applied to subsequent command group siblings in CommandDialog. This makes sense when one command group immediately proceeds another, maintaining even spacing between each group. However, we also end up removing the top padding on command groups that immediately proceed a separator, which makes the spacing between a group and separator visually inconsistent with that between the first group and the command input. To address this, we can update the following class to use the next- sibling combinator (+) instead of the subsequent sibling combinator (~) to target only command groups that immediately proceed another: [&_[cmdk-group]:not([hidden])_~[cmdk-group]]:pt-0 becomes: [&_[cmdk-group]:not([hidden])_+[cmdk-group]]:pt-0
a-jih
force-pushed
the
command-dialog-inconsistent-styles
branch
from
a5943b3 to
a9f8916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
pt-0is applied to subsequent command group siblings inCommandDialog. This makes sense when one command group immediately proceeds another, maintaining even spacing between each group. However, we also end up removing the top padding on command groups that immediately proceed a separator, which makes the spacing between a group and separator visually inconsistent with that between the first group and the command input.To address this, we can update the following class to use the next- sibling combinator (
+) instead of the subsequent sibling combinator (~) to target only command groups that immediately proceed another:becomes:
Screenshots
Observe the spacing above "Settings". It should now be consistent with the spacing above "Suggestions".