Test for link time constants with precompiled SPIR-V#6532
Closed
cheneym2 wants to merge 1 commit intoshader-slang:masterfrom
Closed
Test for link time constants with precompiled SPIR-V#6532cheneym2 wants to merge 1 commit intoshader-slang:masterfrom
cheneym2 wants to merge 1 commit intoshader-slang:masterfrom
Conversation
cheneym2
force-pushed
the
cheneym2/linktimeconstanttestspirv
branch
3 times, most recently
from
c88adf5 to
5f1fd33
Compare
cheneym2
force-pushed
the
cheneym2/linktimeconstanttestspirv
branch
from
5f1fd33 to
580fd53
Compare
cheneym2
force-pushed
the
cheneym2/linktimeconstanttestspirv
branch
3 times, most recently
from
88bfacd to
4b456ff
Compare
When modules contain extern references to globals they don't define, or when the contain exports of globals they may or may not use, utilize SPIR-V linkage attributes to define and use the variables in embedded SPIR-V IR. Fixes shader-slang#6524
cheneym2
force-pushed
the
cheneym2/linktimeconstanttestspirv
branch
from
4b456ff to
933df87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test exercises link time constants used by modules that are precompiled to SPIR-V.
Work on #6524