Merged
Conversation
skallweitNV
force-pushed
the
update-slang-rhi
branch
from
b64c37f to
93fad10
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
skallweitNV
added a commit
to skallweitNV/slang
that referenced
this pull request
Mar 31, 2025
Format code for PR shader-slang#6587
skallweitNV
force-pushed
the
update-slang-rhi
branch
2 times, most recently
from
70d25f5 to
59cfbaa
Compare
Collaborator
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
skallweitNV
added a commit
to skallweitNV/slang
that referenced
this pull request
Apr 22, 2025
Format code for PR shader-slang#6587
skallweitNV
force-pushed
the
update-slang-rhi
branch
from
d24b1db to
07d83b8
Compare
Collaborator
|
CI was failing on the following test, I restarted the test but it may not be an intermittent failure. |
skallweitNV
force-pushed
the
update-slang-rhi
branch
from
30baf29 to
1a235b1
Compare
szihs
pushed a commit
to szihs/slang
that referenced
this pull request
May 7, 2025
* update slang-rhi submodule * slang-rhi API changes * disable agility sdk * fix texture creation * update formats in tests * Extent3D rename * use 1 mip level for 1D textures for Metal * fix texture upload * update to latest slang-rhi * update slang-rhi * format code * update slang-rhi * do not run texture-intrinsics test on metal * update slang-rhi * deal with failing tests * fix more tests * update slang-rhi --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Co-authored-by: Simon Kallweit <simon.kallweit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest
slang-rhiversion.CamelCasestyleI had to disable two tests (adding them
to expected-failure-github.txt):tests/compute/cbuffer-legalize.slang.2 syn (mtl)(@kaizhangNV maybe this is related to the metal parameter block change?!)tests/hlsl-intrinsic/classify-float.slang.5 syn (wgpu)(isnanbug reported here WGSL:isnanreturns false for NaNs #6881)In addition the following tests require the
halfrender feature now for WGPU, because slang-rhi switched WGPU backend to Vulkan which doesn't support thef16extension. Once we can switch back to D3D12 backend again those tests will automatically be re-enabled as thehalfrender feature will be reported again:tests/glsl-intrinsic/shader-subgroup/shader-subgroup-arithmetic_Exclusive.slangtests/glsl-intrinsic/shader-subgroup/shader-subgroup-arithmetic_None.slangtests/glsl-intrinsic/shader-subgroup/shader-subgroup-ballot.slangtests/glsl-intrinsic/shader-subgroup/shader-subgroup-quad.slangtests/glsl-intrinsic/shader-subgroup/shader-subgroup-shuffle-relative.slangtests/glsl-intrinsic/shader-subgroup/shader-subgroup-shuffle.slangtests/hlsl-intrinsic/dot-accumulate.slangtests/hlsl-intrinsic/packed/pack-unpack-float.slangExplicitly removed testing on D3D11 for the following tests. Before, they were ignored because D3D11 didn't report the
hardware-devicerender feature:tests/glsl-intrinsic/unpack-float.slangtests/hlsl-intrinsic/packed/pack-unpack-float.slangtests/hlsl-intrinsic/packed/pack-unpack.slangtests/hlsl-intrinsic/packed/unpack-float.slangtests/hlsl-intrinsic/texture/texture-intrinsics.slang(also fixed expected result, which now matches D3D12)